Fix issue where selected columns persist when creating a new search #10357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
approved these changes
Feb 15, 2017
|
The CI failure seems to be an unrelated error while uploading the artifacts to S3. |
|
jenkins, test this |
@weltenwort I thought about this, but I thought, there might be places that actually rely on this behavior. And there are so many places that use |
lukasolson
added a commit
that referenced
this pull request
Feb 16, 2017
|
Backported to 5.x (5.4) in a3f0b8e. |
|
Similar issue occurs when switching between indexes. Many time different indexes don't share the same fields, thus user needs to remove the old columns one by one. Perhaps a middle ground can be to have a "clear all" button for the selected fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, when you visited discover and added some columns to your doc table, then clicked on "New" (to create a new search), the columns you selected would persist. This was happening because when you create a new search, if there are no columns selected, then the
columnsvariable was being assigned directly to what comes back fromconfig.get('defaultColumns')(and not a copy of this array). This is bad because the directives that use thecolumnsvariable directly modify it, meaning that the next time thatconfig.get('defaultColumns')was invoked, it would return the modified value.This PR resolves this by returning a copy of the array, rather than the array itself.
Fixes #10233.