Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Enterprise Search] Add notices for deactivated users and SMTP callout (#103285) #103376

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

elastic#103285)

* Port elastic#3904 to Kibana

elastic/ent-search#3904

* DRY out logic interfaces

Should have done this long ago

* Port elastic#3920 to Kibana

elastic/ent-search#3920

* Lint fixes

* Remove error state from form

We already did this for the users flyout. Basically changes the dirty state of the form from an error state to just showing “Required”. i18n had not been translated yet for `ATTRIBUTE_VALUE_ERROR`

* Add loading states

* Remove manual disabling of button

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Remove manual disabling of other button

* Lint fixes

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1426 1428 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +18.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @scottybollinger

@kibanamachine kibanamachine merged commit dc9218d into elastic:7.x Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants