Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Enterprise Search] Support active nav links that have both subnav & non-subnav child routes (#103036) #103142

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[7.x] [Enterprise Search] Support active nav links that have both subnav & non-subnav child routes (#103036) #103142

merged 1 commit into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. [Enterprise Search] Support active nav links that have both subnav & … 

    …non-subnav child routes (elastic#103036)

* Update generateNavlink to take an `items` subNav and use it to determine isSelected

+ change getNavLinkActive to early returns
+ tweak tests for readability

* Update WS nav Sources link
- to show active on creation routes but not on single source routes

* Update AS nav Engines link
- should eventually show active on creation routes but not on single engine routes

* Update AS engine creation routing
- so that it correctly shows as a child route of the Engines link

+ update breadcrumbs
    @kibanamachine
    Constance authored and kibanamachine committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    49b32be View commit details
    Browse the repository at this point in the history