[packages] Migrate @kbn/test to Bazel #103122

jbudz · 2021-06-23T15:58:12Z

One step forward on #69706

That PR moves the @kbn/test into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

elasticmachine · 2021-06-23T15:58:14Z

Pinging @elastic/kibana-operations (Team:Operations)

jbudz · 2021-06-24T18:11:00Z

@spalger I'm a little out of my depth here - type check failures are due to conflicting types between mocha and jest. @mistic mentioned you may have some ideas - I see some references to fake mocha types already. Do you have any background info on this?

Partial snippet:

      packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:66:48 - error TS2345: Argument of type 'Mocha.Suite' is not assignable to parameter of type 'import("/home/jon/dev/kibana/packages/kbn
-test/src/functional_test_runner/fake_mocha_types").Suite'.                                                                                                                                                        
                                                                                                                                                                                                                   
      66       await this.lifecycle.beforeTests.trigger(mocha.suite);                                                                                                                                              
                                                        ~~~~~~~~~~~                                                                                                                                                
                                                                                                                                                                                                                   
      packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:69:45 - error TS2345: Argument of type 'Mocha' is not assignable to parameter of type 'import("/home/jon/dev/kibana/packages/kbn-test/
src/functional_test_runner/fake_mocha_types").Mocha'.                                                                                                                                                              
        The types of 'run(...).failures' are incompatible between these types.                                                                                                                                     
          Type 'number' is not assignable to type 'any[]'.                                                                                                                                                         
                                                                                                                                                                                                                   
      69       return await runTests(this.lifecycle, mocha);                                                                                                                                                       
                                                     ~~~~~                                                                                                                                                         
                                                                                                                                                                                                                   
      packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:102:31 - error TS2345: Argument of type 'Mocha.Suite' is not assignable to parameter of type 'import("/home/jon/dev/kibana/packages/kb
n-test/src/functional_test_runner/fake_mocha_types").Suite'.                                                                                                                                                       
        Property 'suiteTag' is missing in type 'Mocha.Suite' but required in type 'import("/home/jon/dev/kibana/packages/kbn-test/src/functional_test_runner/fake_mocha_types").Suite'.                            
                                                                                                                                                                                                                   
      102         testCount: countTests(mocha.suite),

spalger · 2021-06-24T18:12:40Z

packages/kbn-test/tsconfig.json

@@ -1,24 +1,17 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
-    "incremental": false,
+    "allowJs": true,


@jbudz I think this is the cause of the issues, several JS files are used here to avoid types from mocha and jest from both being loaded.

mistic · 2021-06-28T20:43:22Z

@elasticmachine merge upstream

mistic · 2021-06-29T00:39:41Z

@elasticmachine merge upstream

alisonelizabeth

Stack Management changes LGTM (import path changed in snapshot_policy_actions.ts)

tylersmalley · 2021-06-29T15:45:23Z

I verified the junit report is being generated now.

jbudz · 2021-06-29T17:00:21Z

@elasticmachine merge upstream

jbudz · 2021-06-29T19:28:01Z

retest

mistic

LGTM

kibanamachine · 2021-06-29T23:00:36Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 81ec225
Storybooks Preview
This comment will update when the build is complete

History

💚 Build #135235 succeeded 81ec225
💔 Build #135136 failed 9c468ba
💔 Build #134910 failed e97a440
💔 Build #134907 failed bfcc039
💔 Build #134819 failed 673bd4c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-06-29T23:00:36Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 81ec225
Storybooks Preview
This comment will update when the build is complete

History

💚 Build #135235 succeeded 81ec225
💔 Build #135136 failed 9c468ba
💔 Build #134910 failed e97a440
💔 Build #134907 failed bfcc039
💔 Build #134819 failed 673bd4c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jbudz · 2021-06-29T23:07:51Z

retest

jbudz · 2021-06-29T23:09:24Z

@elasticmachine run elasticsearch-ci/docs

kibanamachine · 2021-06-30T01:15:58Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💔 Build #135310 failed 81ec225
💚 Build #135235 succeeded 81ec225
💔 Build #135136 failed 9c468ba
💔 Build #134910 failed e97a440
💔 Build #134907 failed bfcc039

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-30T01:19:11Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jonathan Budzenski <jon@budzenski.me>

jbudz added 5 commits June 23, 2021 10:15

[packages] Migrate @kbn/test to Bazel

34a70d9

emitDeclarationOnly

6693877

cleanup

2224398

rm build scripts

4b77c05

fix types dir

0750752

jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 23, 2021

jbudz requested a review from a team as a code owner June 23, 2021 15:58

jbudz added 4 commits June 23, 2021 11:37

allowJs

8942ffe

update jest-preset paths

6635f59

fix jest integration paths

f01f309

Merge branch 'master' into bazel/test

f70f617

spalger reviewed Jun 24, 2021

View reviewed changes

jbudz added 10 commits June 24, 2021 13:39

remove allowJs

5bead22

Merge branch 'master' into bazel/test

4ba6ab5

re-add babel config

3c14ee3

add extensions arg

d834c37

add extensions

cdb8d01

wip

9faf4aa

cleanup

871da66

fix module resolutions

cf52cd3

re-add emitDeclarationsOnly

85533ce

fix reporter path

c874656

jbudz requested review from a team as code owners June 28, 2021 18:01

Merge branch 'master' into bazel/test

cb8d4f4

Merge branch 'master' into bazel/test

673bd4c

kibanamachine and others added 5 commits June 28, 2021 20:39

Merge branch 'master' into bazel/test

22ae41d

add jest.config.js

4b292dc

Merge branch 'bazel/test' of github.com:jbudz/kibana into bazel/test

bfcc039

,

e97a440

fix junit_reporter path

5ce2045

alisonelizabeth approved these changes Jun 29, 2021

View reviewed changes

Merge branch 'master' into bazel/test

9c468ba

Merge branch 'master' into bazel/test

81ec225

jbudz requested a review from mistic June 29, 2021 19:35

jbudz enabled auto-merge (squash) June 29, 2021 19:36

mistic approved these changes Jun 29, 2021

View reviewed changes

mistic mentioned this pull request Jun 29, 2021

chore(NA): moving @kbn/es-archiver into bazel #103770

Merged

jbudz merged commit bed5b6d into elastic:master Jun 30, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 30, 2021

[packages] Migrate @kbn/test to Bazel (elastic#103122)

79b4847

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine mentioned this pull request Jun 30, 2021

[7.x] [packages] Migrate @kbn/test to Bazel (#103122) #103812

Merged

kibanamachine added a commit that referenced this pull request Jun 30, 2021

[packages] Migrate @kbn/test to Bazel (#103122) (#103812)

4695120

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jonathan Budzenski <jon@budzenski.me>

mistic mentioned this pull request Jul 1, 2021

Use Bazel for Kibana builds #69706

Closed

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[packages] Migrate @kbn/test to Bazel #103122

[packages] Migrate @kbn/test to Bazel #103122

jbudz commented Jun 23, 2021

elasticmachine commented Jun 23, 2021

jbudz commented Jun 24, 2021 •

edited

Loading

spalger Jun 24, 2021

mistic commented Jun 28, 2021

mistic commented Jun 29, 2021

alisonelizabeth left a comment

tylersmalley commented Jun 29, 2021 •

edited

Loading

jbudz commented Jun 29, 2021

jbudz commented Jun 29, 2021

mistic left a comment

kibanamachine commented Jun 29, 2021

kibanamachine commented Jun 29, 2021

jbudz commented Jun 29, 2021

jbudz commented Jun 29, 2021

kibanamachine commented Jun 30, 2021

kibanamachine commented Jun 30, 2021

[packages] Migrate @kbn/test to Bazel #103122

[packages] Migrate @kbn/test to Bazel #103122

Conversation

jbudz commented Jun 23, 2021

elasticmachine commented Jun 23, 2021

jbudz commented Jun 24, 2021 • edited Loading

spalger Jun 24, 2021

Choose a reason for hiding this comment

mistic commented Jun 28, 2021

mistic commented Jun 29, 2021

alisonelizabeth left a comment

Choose a reason for hiding this comment

tylersmalley commented Jun 29, 2021 • edited Loading

jbudz commented Jun 29, 2021

jbudz commented Jun 29, 2021

mistic left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 29, 2021

⏳ Build in-progress, with failures

History

kibanamachine commented Jun 29, 2021

⏳ Build in-progress, with failures

History

jbudz commented Jun 29, 2021

jbudz commented Jun 29, 2021

kibanamachine commented Jun 30, 2021

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Jun 30, 2021

💚 Backport successful

jbudz commented Jun 24, 2021 •

edited

Loading

tylersmalley commented Jun 29, 2021 •

edited

Loading