Add info notifications for adding visualizations to the dashboard #10310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @kobelb and @alexfrancoeur - I moved the original PR into this one since the diffs were too great to rebase with master. I'll merge soon unless anyone has any last input. |
|
jenkins test this |
|
@stacey-gammon looks good to me. I kept getting this error though. The notifications worked as expected otherwise
|
stacey-gammon
force-pushed
the
info-notifications-on-add
branch
from
87dd05c to
98237e0
Compare
|
That's really weird @alexfrancoeur, I'm going to rebase with master and hope it fixes that issue. The PR changes are really minor so shouldn't cause any issues. |
stacey-gammon
added
review
v5.4.0
Feature:Dashboard
|
@stacey-gammon just checked out and all looks good - no more errors on my end 👍 |
stacey-gammon
pushed a commit
that referenced
this pull request
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported #9961 into a new PR since the code in master changed so much.