Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Updating generator to install/update the endpoint package during setup #103094

Merged

Conversation

jonathan-buttner
Copy link
Contributor

@jonathan-buttner jonathan-buttner commented Jun 23, 2021

Fleet no longer installs the endpoint package by default when the /setup API is requested (#102219). The resolver generator relied on /setup installing the endpoint package so that the mappings would be in place before it sent data to Elasticsearch. This PR adds functionality to the generator to install/update the endpoint package directly during the scripts setup.

I was hoping to do a gif but it was taking too long to record the whole process haha.

Example run
yarn test:generate -f -s resolver --gen 3 --pr 100 --pt 100 --delete
yarn run v1.22.10
$ node scripts/endpoint/resolver_generator -f -s resolver --gen 3 --pr 100 --pt 100 --delete
Creating and indexing documents took: 46728ms
✨  Done in 71.72s.

image

@jonathan-buttner jonathan-buttner added v8.0.0 Feature:Resolver Security Solution Resolver feature Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 labels Jun 23, 2021
@jonathan-buttner jonathan-buttner marked this pull request as ready for review June 23, 2021 14:00
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner June 23, 2021 14:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Feature:Resolver)

@jonathan-buttner jonathan-buttner added the release_note:skip Skip the PR/issue when compiling release notes label Jun 23, 2021
@jonathan-buttner jonathan-buttner added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
…3094) (#103127)

Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants