Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Convert Synonyms page to new page template (#102828) #103040

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* Convert Synonyms page to new page template

* Update empty state for new page template

- Remove EuiPanel wrapper - KibanaPageTemplate does that automatically for us

- Include SynonymModal, required for header create button to work as expected

* Update router

* [UI polish] Proposed page description copy from Davey

- see elastic@9807bf2

* [UI polish] Add plus icon to create button

- To match other create buttons across app
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB -611.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit 909e035 into elastic:7.x Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants