Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search][Polish] API Logs empty state #102998

Merged
merged 2 commits into from
Jun 22, 2021
Merged

[App Search][Polish] API Logs empty state #102998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e55ff
Re-add noItemsMessage to ApiLogsTable
cee-chen Jun 22, 2021
f91b283
Tweak API logs empty state copy
cee-chen Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...e_search/public/applications/app_search/components/api_logs/components/api_logs_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { ApiLogsLogic } from '../index';
import { ApiLog } from '../types';
import { getStatusColor } from '../utils';

import { EmptyState } from './';

import './api_logs_table.scss';

interface Props {
Expand Down Expand Up @@ -108,6 +110,7 @@ export const ApiLogsTable: React.FC<Props> = ({ hasPagination }) => {
items={apiLogs}
responsive
loading={dataLoading}
noItemsMessage={<EmptyState />}
{...paginationProps}
/>
);
Expand Down
2 changes: 1 addition & 1 deletion ...search/public/applications/app_search/components/api_logs/components/empty_state.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('EmptyState', () => {
.find(EuiEmptyPrompt)
.dive();

expect(wrapper.find('h2').text()).toEqual('Perform your first API call');
expect(wrapper.find('h2').text()).toEqual('No API events in the last 24 hours');
expect(wrapper.find(EuiButton).prop('href')).toEqual(
expect.stringContaining('/api-reference.html')
);
Expand Down
4 changes: 2 additions & 2 deletions ...rise_search/public/applications/app_search/components/api_logs/components/empty_state.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ export const EmptyState: React.FC = () => (
title={
<h2>
{i18n.translate('xpack.enterpriseSearch.appSearch.engine.apiLogs.emptyTitle', {
defaultMessage: 'Perform your first API call',
defaultMessage: 'No API events in the last 24 hours',
})}
</h2>
}
body={
<p>
{i18n.translate('xpack.enterpriseSearch.appSearch.engine.apiLogs.emptyDescription', {
defaultMessage: "Check back after you've performed some API calls.",
defaultMessage: 'Logs will update in real-time when an API request occurs.',
})}
</p>
}
Expand Down