Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppService] fix deepLinks being lost when updating the app with other fields #102895

Merged
merged 2 commits into from
Jun 22, 2021
Merged

[AppService] fix deepLinks being lost when updating the app with other fields #102895

merged 2 commits into from
Jun 22, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jun 22, 2021 •
edited
Loading

Summary

Fix a bug causing an application's deepLinks to be erased when an appUpdater emits a value that does not contain deepLinks

Checklist

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 labels Jun 22, 2021
@pgayvallet pgayvallet marked this pull request as ready for review June 22, 2021 13:39
@pgayvallet pgayvallet requested a review from a team as a code owner June 22, 2021 13:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@smith smith mentioned this pull request Jun 22, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 410.7KB 410.7KB -10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 016259d into elastic:master Jun 22, 2021
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Jun 22, 2021
@pgayvallet
[AppService] fix deepLinks being lost when updating the app with othe…
300803c 
…r fields (elastic#102895)

* fix app updater for deepLinks

* improve implem
@pgayvallet pgayvallet mentioned this pull request Jun 22, 2021
Merged
pgayvallet added a commit that referenced this pull request Jun 22, 2021
@pgayvallet
[AppService] fix deepLinks being lost when updating the app with othe…
8e2c654 
…r fields (#102895) (#102947)

* fix app updater for deepLinks

* improve implem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @elasticmachine @kibanamachine @Bamieh