[App Search] Migrate Source Engines & Crawler pages to new page template #102848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
- move away from color=secondary, EUI is eventually deprecating it - add (+) icon to match other views
JasonStoltz
approved these changes
Jun 22, 2021
cee-chen
commented
Jun 22, 2021
...plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @JasonStoltz |
💔 Backport failed
To backport manually run: |
cee-chen
pushed a commit
that referenced
this pull request
Jun 23, 2021
…ate (#102848) (#103030) * Convert meta engines Source Engines view to new page template * Convert CrawlerLanding to new page template * Convert CrawlerOverview to new page template * Update routers * Misc Source Engines UI polish - move away from color=secondary, EUI is eventually deprecating it - add (+) icon to match other views * Fix bad merge conflict # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_overview.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_router.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/crawler_router.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the Source Engine view & the Crawler views (+ small UI polish change of the CrawlerLanding panel going from shadowed to bordered). As always, follow along by commit (and turn off whitespace diffs)
Screencaps
Source Engines:
Crawler:
Checklist