[App Search] Convert API Logs page to new page template + empty state polish #102820
Conversation
- Will be used by new page template
+ use new empty state + add tests clarifying loading UX
cee-chen
added
auto-backport
| expect(wrapper.prop('isLoading')).toEqual(true); | ||
| }); | ||
|
|
||
| it('does not re-render a full-page loading state after initial page load (uses component-level loading state instead)', () => { |
There was a problem hiding this comment.
Note that the component level loading here is the EuiBasicTable's default loading prop. The only time data reloads on this page is when users are paginating between pages of logs, so it makes sense to handle that loading UX at the component level instead of re-flashing a full-page loading state.
The test name was already getting really long though so I didn't want to add all that extra context to it 🤪
| href={`${DOCS_PREFIX}/api-reference.html`} | ||
| > | ||
| {i18n.translate('xpack.enterpriseSearch.appSearch.engine.searchUI.empty.buttonLabel', { | ||
| defaultMessage: 'View the API reference', |
There was a problem hiding this comment.
This document link is new, I thought it made sense to provide a link teaching people how to make API calls if needed. Feel free to leave copy feedback
|
Not sure why this CI failed but not going to bother to re-run tests right now, they'll have to rerun anyway later to get latest master / fix router merge conflicts |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
… polish (elastic#102820) * Convert API Logs noItemsMessage to its own empty state prompt - Will be used by new page template * Convert API Logs view to new page template + use new empty state + add tests clarifying loading UX * Update router * Fix i18n ID
… polish (#102820) (#102987) * Convert API Logs noItemsMessage to its own empty state prompt - Will be used by new page template * Convert API Logs view to new page template + use new empty state + add tests clarifying loading UX * Update router * Fix i18n ID Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the API Logs view, and moves its empty state to a top-level concern to match other existing pages. It also adds a documentation link for funsies. As always, follow along by commit (and turn off whitespace diffs)
Screencaps
Checklist