Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Convert Search UI view to new page template + minor UI polish #102813

Merged
merged 6 commits into from
Jun 22, 2021
Merged

[App Search] Convert Search UI view to new page template + minor UI polish #102813

merged 6 commits into from
Jun 22, 2021

Commits on Jun 21, 2021

  1. Convert Search UI view to use new page template 

    + update tests TODO
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    731a99e View commit details
    Browse the repository at this point in the history

  2. [UX polish] Add empty state to Search UI view 

    - On a totally new engine, all pages except this one* had an empty state, so per Davey's recommendations I whipped up a new empty state for this page

* Overview has a custom 'empty' state, analytics does not have an empty state
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    26f86ab View commit details
    Browse the repository at this point in the history

  3. Update router

    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    343aaf9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into kibana-page-template-as-5

    Constance committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    19e45da View commit details
    Browse the repository at this point in the history

  5. Fix bad merge conflict resolution

    Constance committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    fb04e85 View commit details
    Browse the repository at this point in the history

  6. [Polish] Copy feedback proposed by Davey 

    - see elastic@cbc3706
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8255332 View commit details
    Browse the repository at this point in the history