[App Search] Convert Documents views to new page template + minor UI polish #102807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- per Davey's previous approval
cee-chen
added
release_note:skip
byronhulcher
approved these changes
Jun 21, 2021
| @@ -26,7 +27,7 @@ export const SearchExperienceContent: React.FC = () => { | |||
|
|
|||
| const { isMetaEngine, engine } = useValues(EngineLogic); | |||
|
|
|||
| if (!wasSearched) return null; | |||
| if (!wasSearched) return <Loading />; | |||
cee-chen
commented
Jun 21, 2021
| rightSideItems: | ||
| myRole.canManageEngineDocuments && !isMetaEngine ? [<DocumentCreationButton />] : [], | ||
| }} | ||
| isEmptyState={!engine.document_count} |
There was a problem hiding this comment.
Oh, totally forgot to mention - I have plans to pull this out to a flat isEngineEmpty selector, but I'm going to do that in a later tech debt/polish PR, since I'll also be using that check for the engine overview
|
Merging for speed / to reduce churn on merges/rebases tomorrow - @JasonStoltz if you have any issues or change requests with this PR, definitely let me know and I can open a follow-up |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 21, 2021
…polish (elastic#102807) * Convert Documents view to new page template * [UI polish] Move empty state to top-level instead of showing full UI - per Davey's previous approval * [UX polish] Show loading indicator on initial documents page load * Convert single Document detail view to new page template * Update router
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 21, 2021
…polish (#102807) (#102824) * Convert Documents view to new page template * [UI polish] Move empty state to top-level instead of showing full UI - per Davey's previous approval * [UX polish] Show loading indicator on initial documents page load * Convert single Document detail view to new page template * Update router Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the Documents view, and additionally handles some UI polish in the form of moving the empty state top level (approved by Davey), and adding a loading indicator on initial page load. As always, follow along by commit (and turn off whitespace diffs)!
Screencaps
New empty state:
Walkthrough screencap + loading state:
Checklist