Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Engines Overview polish pass #102778

Merged
merged 9 commits into from
Jun 21, 2021
Merged

[App Search] Engines Overview polish pass #102778

merged 9 commits into from
Jun 21, 2021

Commits on Jun 21, 2021

  1. Split up engines vs. meta engines into separate panels 

    - per Davey's feedback from earlier UI passes
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    749b9ea View commit details
    Browse the repository at this point in the history

  2. DRY out manual header/spacing to reusable DataPanel component 

    + update DataPanel icon typing to not error when passed a custom icon/svg

- kudos again to Davey for the component
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    62653fb View commit details
    Browse the repository at this point in the history

  3. Typography tweaks 

    - Update DataPanel component to accept a custom titleSize (to maintain previous UI/sizing)

- Fix meta engines empty prompt title heading to follow heading levels + tweak sizing to not be larger than panel heading
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    48c6c49 View commit details
    Browse the repository at this point in the history

  4. Set up new license CTA button for upcoming meta engines CTA 

    falls back to a documentation link! so fancy
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f25efb8 View commit details
    Browse the repository at this point in the history

  5. Update Enterprise Search Overview to use new license button

    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    3bc90b3 View commit details
    Browse the repository at this point in the history

  6. Add new Meta Engines license upgrade CTA 

    - Reuse some copy from Meta Engines creation view
- Reuse DataPanel so visuals stay consistent + it looks similar to CTA on Enterprise Search Overview
- Update DataPanel to allow buttons to be responsive + conditionally load spacer between header & children
    @cee-chen
    cee-chen committed Jun 21, 2021
    3 Configuration menu
    Copy the full SHA
    27eadce View commit details
    Browse the repository at this point in the history

  7. Improve responsiveness of app when platinum license changes 

    Previously, routes/apps were going off the static data passed from the server which was only initialized once on page load. hasPlatinumLicense however changes dynamically and in real-time, removing the need for a hard page refresh.

I could have replaced all `canManageMetaEngine` flags with `isPlatinum && canManageEngines`, but I thought baking license checks into the main ability would be more scalable and potentially open the way to other license-based flags also being dynamic.
    @cee-chen
    cee-chen committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f90c3e8 View commit details
    Browse the repository at this point in the history

  8. [PR feedback] Typos in test names 

    Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
    @JasonStoltz
    Constance and JasonStoltz committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0f74026 View commit details
    Browse the repository at this point in the history

  9. Fix failing test 

    Missed updating the heading level
    Constance committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    49ed5ad View commit details
    Browse the repository at this point in the history