Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Convert Engines overview & engine creation to new page template (#102677) #102769

Merged
merged 1 commit into from
Jun 21, 2021

Commits on Jun 21, 2021

  1. [App Search] Convert Engines overview & engine creation to new page t…

    …emplate (elastic#102677)
    
    * Convert Engine Creation page to new page template
    
    + simplify EuiForm/form to 1 level of nesting
    
    * Convert Meta Engine Creation page to new page template
    
    * Initial conversion of Engines overview to new page template
    
    * Engines Overview: simplify loading & empty state to use new page template props
    
    * Engines Overview: simplify header
    
    - now that the header/actions, chrome/telemetry, & empty state etc. are all DRY'd out by the template, there's no need for a separate header component
    - we can simply dry out the header action, which will shortly be removed with the 7.14 launch
    
    - note: for empty state changes: mostly indenting, the new template automatically creates a subdued panel for us in empty state so no need to include one manually
    
    * Fix broken test mocks
    
    I definitely should not have been importing the index file I'm mocking, but why did this only break now?? :psyduck:
    
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    Constance and kibanamachine committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b262d21 View commit details
    Browse the repository at this point in the history