Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Convert Engines overview & engine creation to new page template #102677

Merged
merged 7 commits into from
Jun 21, 2021

Commits on Jun 18, 2021

  1. Convert Engine Creation page to new page template

    + simplify EuiForm/form to 1 level of nesting
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    21c864b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7644574 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6525da6 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    4cce984 View commit details
    Browse the repository at this point in the history
  2. Engines Overview: simplify header

    - now that the header/actions, chrome/telemetry, & empty state etc. are all DRY'd out by the template, there's no need for a separate header component
    - we can simply dry out the header action, which will shortly be removed with the 7.14 launch
    
    - note: for empty state changes: mostly indenting, the new template automatically creates a subdued panel for us in empty state so no need to include one manually
    cee-chen committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    6d7446d View commit details
    Browse the repository at this point in the history
  3. Fix broken test mocks

    I definitely should not have been importing the index file I'm mocking, but why did this only break now?? :psyduck:
    cee-chen committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    c7dbf5d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Configuration menu
    Copy the full SHA
    024af45 View commit details
    Browse the repository at this point in the history