[App Search] Convert Settings & Credentials pages to new page template #102671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add missing ability check around route
+ add missing ability check around route
cee-chen
added
release_note:skip
cee-chen
commented
Jun 18, 2021
| pageHeader={{ pageTitle: CREDENTIALS_TITLE }} | ||
| > | ||
| {shouldShowCredentialsForm && <CredentialsFlyout />} | ||
| <EuiPanel color="subdued" className="eui-textCenter"> |
There was a problem hiding this comment.
2 quick notes,
- This large diff block is mostly whitespace diff shenanigans, so don't forget to disable those
- I did a general panel pass with Davey in light of the new page template header having a bottom border, and he approved converting this panel from bordered to subdued
byronhulcher
approved these changes
Jun 21, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
cee-chen
pushed a commit
that referenced
this pull request
Jun 21, 2021
#102671) (#102823) * Convert Settings to new page template + add missing ability check around route * Convert Credentials to new page template + add missing ability check around route * [Tests refactor] DRY out repeated ability tests to a helper Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the top-level Settings & Credentials (+ adds missing ability checks and a test refactor). As always, follow along by commit (and turn off whitespace diffs)!
Screencaps
NOTE: The engine nav item currently has a small dropdown arrow next to it that will go away once the real engine subnav is implemented.
Checklist