-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workplace Search] Convert Sources pages to new page template (+ personal dashboard) #102592
Commits on Jun 18, 2021
-
Refactor PersonalDashboardLayout to more closely match new page template
- Remove references to enterpriseSearchLayout CSS (which will be removed in an upcoming PR) - Prefer to lean more heavily on default EuiPage props/CSS/etc. - Handle conditional sidebar logic in this layout rather than passing it in as a prop - Update props & DRY concerns to more closely match WorkplaceSearchPageTemplate - e.g. isLoading & pageChrome (mostly for document titles) - make FlashMessage and readOnlyMode work OOTB w/o props)
Configuration menu - View commit details
-
Copy full SHA for 750f227 - Browse repository at this point
Copy the full SHA 750f227View commit details -
Convert Source subnav to EuiSideNav format
+ update PrivateSourcesSidebar to use EuiSIdeNav
Configuration menu - View commit details
-
Copy full SHA for b4ebfa4 - Browse repository at this point
Copy the full SHA b4ebfa4View commit details -
- removing wrapping layouts, flash messages, chrome/telemetry
Configuration menu - View commit details
-
Copy full SHA for 1fffcf6 - Browse repository at this point
Copy the full SHA 1fffcf6View commit details -
Refactor SourceRouter into shared layout component
- Remove license callout, page header, and page chrome/telemetry - NOTE: The early page isLoading behavior (lines 51-) is required to prevent a flash of a completely empty page (instead of preserving the layout/side nav while loading). We cannot let the page fall through to the route because some routes are conditionally rendered based on isCustomSource. - FWIW: App Search has a similar isLoading early return with its Engine sub nav, and also a similar AnalyticsLayout for DRYing out repeated concerns/UI elements within Analytics subroutes.
Configuration menu - View commit details
-
Copy full SHA for 637ba53 - Browse repository at this point
Copy the full SHA 637ba53View commit details -
Convert all single source views to new page template
- Mostly removing isLoading tests - NOTE: Schema page could *possibly* use the new isEmptyState/emptyState page template props, but would need some layout reshuffling
Configuration menu - View commit details
-
Copy full SHA for 7bb4891 - Browse repository at this point
Copy the full SHA 7bb4891View commit details -
Convert Add Source pages to conditional page templates
- Opted to give these pages their own conditional layout logic - this could possibly be DRY'd out - There is possibly extra cleanup here on this file that could have been done (e.g. empty state, titles, etc.) in light of the new templates - but I didn't want to spend extra time here and went with creating as few diffs as possible
Configuration menu - View commit details
-
Copy full SHA for 91c51f9 - Browse repository at this point
Copy the full SHA 91c51f9View commit details -
Convert separate Organization Sources & Private Sources views to new …
…page templates + fix Link to EuiButtonTo on Organization Sources view
Configuration menu - View commit details
-
Copy full SHA for 7f42518 - Browse repository at this point
Copy the full SHA 7f42518View commit details -
Update Account Settings with personal layout + write tests
+ add related KibanaLogic branch coverage
Configuration menu - View commit details
-
Copy full SHA for 6c305e5 - Browse repository at this point
Copy the full SHA 6c305e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bea24e - Browse repository at this point
Copy the full SHA 8bea24eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d77ee41 - Browse repository at this point
Copy the full SHA d77ee41View commit details -
[Proposal] Update schema errors routing to better work with nav/bread…
…crumbs - `exact` is required to make the parent schemas/ not gobble schema/{errorId} - added bonus breadcrumb for nicer schema navigation UX - No tests need to update AFAICT
Configuration menu - View commit details
-
Copy full SHA for b6a62b6 - Browse repository at this point
Copy the full SHA b6a62b6View commit details
Commits on Jun 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 96ef51c - Browse repository at this point
Copy the full SHA 96ef51cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57dcd76 - Browse repository at this point
Copy the full SHA 57dcd76View commit details -
Configuration menu - View commit details
-
Copy full SHA for baf2ab6 - Browse repository at this point
Copy the full SHA baf2ab6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e562f63 - Browse repository at this point
Copy the full SHA e562f63View commit details