Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Convert Sources pages to new page template (+ personal dashboard) #102592

Merged
merged 15 commits into from
Jun 22, 2021

Commits on Jun 18, 2021

  1. Refactor PersonalDashboardLayout to more closely match new page template

    - Remove references to enterpriseSearchLayout CSS (which will be removed in an upcoming PR)
    
    - Prefer to lean more heavily on default EuiPage props/CSS/etc.
    
    - Handle conditional sidebar logic in this layout rather than passing it in as a prop
    
    - Update props & DRY concerns to more closely match WorkplaceSearchPageTemplate
      - e.g. isLoading & pageChrome (mostly for document titles)
      - make FlashMessage and readOnlyMode work OOTB w/o props)
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    750f227 View commit details
    Browse the repository at this point in the history
  2. Convert Source subnav to EuiSideNav format

    + update PrivateSourcesSidebar to use EuiSIdeNav
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    b4ebfa4 View commit details
    Browse the repository at this point in the history
  3. Update routers

    - removing wrapping layouts, flash messages, chrome/telemetry
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1fffcf6 View commit details
    Browse the repository at this point in the history
  4. Refactor SourceRouter into shared layout component

    - Remove license callout, page header, and page chrome/telemetry
    
    - NOTE: The early page isLoading behavior (lines 51-) is required to prevent a flash of a completely empty page (instead of preserving the layout/side nav while loading). We cannot let the page fall through to the route because some routes are conditionally rendered based on isCustomSource.
    
    - FWIW: App Search has a similar isLoading early return with its Engine sub nav, and also a similar AnalyticsLayout for DRYing out repeated concerns/UI elements within Analytics subroutes.
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    637ba53 View commit details
    Browse the repository at this point in the history
  5. Convert all single source views to new page template

    - Mostly removing isLoading tests
    - NOTE: Schema page could *possibly* use the new isEmptyState/emptyState page template props, but would need some layout reshuffling
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7bb4891 View commit details
    Browse the repository at this point in the history
  6. Convert Add Source pages to conditional page templates

    - Opted to give these pages their own conditional layout logic - this could possibly be DRY'd out
    
    - There is possibly extra cleanup here on this file that could have been done (e.g. empty state, titles, etc.) in light of the new templates - but I didn't want to spend extra time here and went with creating as few diffs as possible
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    91c51f9 View commit details
    Browse the repository at this point in the history
  7. Convert separate Organization Sources & Private Sources views to new …

    …page templates
    
    + fix Link to EuiButtonTo on Organization Sources view
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    7f42518 View commit details
    Browse the repository at this point in the history
  8. Update Account Settings with personal layout + write tests

    + add related KibanaLogic branch coverage
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6c305e5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8bea24e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d77ee41 View commit details
    Browse the repository at this point in the history
  11. [Proposal] Update schema errors routing to better work with nav/bread…

    …crumbs
    
    - `exact` is required to make the parent schemas/ not gobble schema/{errorId}
    
    - added bonus breadcrumb for nicer schema navigation UX
    
    - No tests need to update AFAICT
    cee-chen committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    b6a62b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Configuration menu
    Copy the full SHA
    96ef51c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57dcd76 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    baf2ab6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e562f63 View commit details
    Browse the repository at this point in the history