Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Convert Overview & Security pages to new page template #102444

Merged
merged 3 commits into from
Jun 17, 2021
Merged

[Workplace Search] Convert Overview & Security pages to new page template #102444

merged 3 commits into from
Jun 17, 2021

Commits on Jun 17, 2021

  1. Convert WS Overview page to new page template

    @cee-chen
    cee-chen committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7602efe View commit details
    Browse the repository at this point in the history

  2. Misc Overview refactors 

    - Fix extra spacing caused by hidden onboarding steps

- Default page title to "Organization overview" instead of to onboarding title which flashes during loading

- Prefer shallow over mount (will matter later, when WorkplaceSearchPageTemplate nav includes more kea logic)
    @cee-chen
    cee-chen committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    281e7a6 View commit details
    Browse the repository at this point in the history

  3. Convert Security page to new page template 

    + misc ux enhancement disabling header actions while data is still loading
    @cee-chen
    cee-chen committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1616f07 View commit details
    Browse the repository at this point in the history