Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor observability plugin breadcrumbs #102290

Merged
merged 5 commits into from
Jun 17, 2021
Merged

Refactor observability plugin breadcrumbs #102290

merged 5 commits into from
Jun 17, 2021

Commits on Jun 16, 2021

  1. Refactor observability plugin breadcrumbs 

    Previously the observability plugin set the page title and breadcrumbs in the main app rendering component based on the `breadcrumb` property of the current route.

In addition, there's a `useBreadcrumb` hook used by the UX app, exploratory view, and cases.

The conflict between these was creating situations where neither would work and the breadcrumbs would just show "Kibana".

Remove the breadcrumb properties from the routes and the main app breadcrumb handling and just use `useBreadcrumb` on all pages.

Fixes elastic#102131.
    @smith
    smith committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    394b994 View commit details
    Browse the repository at this point in the history

  2. i18n fix

    @smith
    smith committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    630b52d View commit details
    Browse the repository at this point in the history

  3. Make i18n keys a bit shorter

    @smith
    smith committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    db2561d View commit details
    Browse the repository at this point in the history

  4. Only call addClickHandlers once

    @smith
    smith committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    59196b6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into nls/obs-bread

    @smith
    smith committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    eba7482 View commit details
    Browse the repository at this point in the history