-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rollups] Migrate to new page layout #102268
Changes from 8 commits
ec40e56
ad7aaf0
8808bbd
d62a109
2555fd3
e47d701
47bf842
42c8b8e
c9095d2
8710824
58ccc7e
0a8047b
edbb63c
84f9f2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
* 2.0. | ||
*/ | ||
|
||
import React, { Component, Fragment } from 'react'; | ||
import React, { Component } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import { cloneDeep, debounce, first, mapValues } from 'lodash'; | ||
|
||
|
@@ -18,11 +18,10 @@ import { | |
EuiCallOut, | ||
EuiLoadingKibana, | ||
EuiOverlayMask, | ||
EuiPageContent, | ||
EuiPageContentHeader, | ||
EuiPageContentBody, | ||
EuiPageHeader, | ||
EuiSpacer, | ||
EuiStepsHorizontal, | ||
EuiTitle, | ||
} from '@elastic/eui'; | ||
|
||
import { | ||
|
@@ -522,44 +521,45 @@ export class JobCreateUi extends Component { | |
} | ||
|
||
saveErrorFeedback = ( | ||
<Fragment> | ||
<> | ||
<EuiSpacer /> | ||
|
||
<EuiCallOut title={message} icon="cross" color="danger"> | ||
{errorBody} | ||
</EuiCallOut> | ||
|
||
<EuiSpacer /> | ||
</Fragment> | ||
</> | ||
); | ||
} | ||
|
||
return ( | ||
<Fragment> | ||
<EuiPageContent> | ||
<EuiPageContentHeader> | ||
<EuiTitle size="l"> | ||
<h1> | ||
<FormattedMessage | ||
id="xpack.rollupJobs.createTitle" | ||
defaultMessage="Create rollup job" | ||
/> | ||
</h1> | ||
</EuiTitle> | ||
</EuiPageContentHeader> | ||
|
||
{saveErrorFeedback} | ||
<EuiPageContentBody restrictWidth style={{ width: '100%' }}> | ||
<EuiPageHeader | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks good! But wondering if we should ask EUI whether if this should have a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! Yes, I believe it should - fixed. |
||
pageTitle={ | ||
<FormattedMessage | ||
id="xpack.rollupJobs.createTitle" | ||
defaultMessage="Create rollup job" | ||
/> | ||
} | ||
/> | ||
|
||
<> | ||
<EuiStepsHorizontal steps={this.getSteps()} /> | ||
|
||
{saveErrorFeedback} | ||
|
||
<EuiSpacer /> | ||
|
||
{this.renderCurrentStep()} | ||
|
||
<EuiSpacer size="l" /> | ||
|
||
{this.renderNavigation()} | ||
</EuiPageContent> | ||
{savingFeedback} | ||
</Fragment> | ||
|
||
{savingFeedback} | ||
</> | ||
</EuiPageContentBody> | ||
); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary anymore; I included a screenshot in the PR description when there are no matching results.