Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Set up initial KibanaPageTemplate #102170

Merged
merged 10 commits into from
Jun 16, 2021
Merged

[Enterprise Search] Set up initial KibanaPageTemplate #102170

merged 10 commits into from
Jun 16, 2021

Commits on Jun 15, 2021

  1. Set up shared EnterpriseSearchPageTemplate component

    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    b8258d5 View commit details
    Browse the repository at this point in the history

  2. Set up product-specific page templates + setPageChrome 

    + misc tech debt - create AS components/layout/index.ts for imports
    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    1b041f7 View commit details
    Browse the repository at this point in the history

  3. Set up navigation helpers for EuiSideNav usage 

    - Update react_router_helpers to pass back props as a plain JS obj instead of only working with React components (+ update react components to use new simpler helper)

- Convert SideNavLink active logic to a plain JS helper
    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    09c2497 View commit details
    Browse the repository at this point in the history

  4. Set up top-level product navigations 

    NYI: sub navigations (future separate PRs)
    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d1861c0 View commit details
    Browse the repository at this point in the history

  5. Set up test_helpers for inspecting pageHeaders 

    - primarily useful for rightSideItems, which often contain conditional logic
    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    1675342 View commit details
    Browse the repository at this point in the history

  6. Initial example: Convert RoleMappings views to new page template 

    Minor refactors:
+ remove unnecessary type union
+ fix un-i18n'ed product names
+ add full stop to documentation sentence
+ add semantic HTML tags around various page landmarks (header, section)
    @cee-chen
    cee-chen committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    4b1d526 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. EUI feedback: add empty root parent section

    @cee-chen
    cee-chen committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    74956bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kibana-page-template-1

    @cee-chen
    cee-chen committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    fb0be5d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into kibana-page-template-1

    @kibanamachine
    kibanamachine committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    aaf3705 View commit details
    Browse the repository at this point in the history

  4. Revert Role Mappings union type removal 

    - but shenanigans it a bit to take our i18n'd shared product names (requires as const assertion)

- done to reduce merge conflicts for Scotty / make his life (hopefully) a bit easier between ent-search and Kibana
    @cee-chen
    cee-chen committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    b747586 View commit details
    Browse the repository at this point in the history