Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Refactor Role mappings to use single endpoint #102096

Merged
merged 5 commits into from
Jun 15, 2021
Merged

[Enterprise Search] Refactor Role mappings to use single endpoint #102096

merged 5 commits into from
Jun 15, 2021

Commits on Jun 14, 2021

  1. Add tooltip back to table row 

    This was missed when refactoring the table to an EUI component. Built-in mappings have tooltips and don’t have IDs and need to show tooltips instead of actions.
    @scottybollinger
    scottybollinger committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    ae32dfe View commit details
    Browse the repository at this point in the history

  2. Fix roleType display 

    Also missed in the refactor. Made a mistake when copying/pasting
    @scottybollinger
    scottybollinger committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    f37d2ea View commit details
    Browse the repository at this point in the history

  3. Refactor logic files to use single endpoint for UI props 

    As a part of this feature, we are now passing all props needed for the UI in the list endpoint. Previously, whether creating a new mapping, or updating an existing mapping, an endpoint had to be called to fetch the data needed for display. Now all this data comes from the initial fetching of mappings and the other endpoints are no longer needed.
    @scottybollinger
    scottybollinger committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    4dccd34 View commit details
    Browse the repository at this point in the history

  4. Refactor WS test to match AS 

    There was an issue where 100% test coverage was not achieved in Workplace Search. This had already been fixed in App Search by refactoring. This changes the code and test in Workplace Search to match
    @scottybollinger
    scottybollinger committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    cc97d98 View commit details
    Browse the repository at this point in the history

  5. Remove server routes

    @scottybollinger
    scottybollinger committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d61e4bd View commit details
    Browse the repository at this point in the history