Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Docs for time shift #102048

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

flash1293
Copy link
Contributor

Adds a section for time shifts

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 14, 2021
@flash1293 flash1293 marked this pull request as ready for review June 14, 2021 16:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flash1293 Adding it to the tutorial is good, but I think you might be missing some other docs:

  • Nothing in this tutorial says you can type custom time shifts
  • There's no reference content added to the dedicated Lens page
  • I think I've covered this in a separate PR, but there's no reference content when comparing the editor features

docs/user/dashboard/lens-advanced.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens-advanced.asciidoc Show resolved Hide resolved
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the docs! I made some punctuation and grammatical changes, and a formatting suggestion. Otherwise, LGTM!

docs/user/dashboard/lens-advanced.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens-advanced.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens-advanced.asciidoc Outdated Show resolved Hide resolved
@flash1293
Copy link
Contributor Author

Thanks @wylieconlon - addressed the specific changes.

I'm not sure about

There's no reference content added to the dedicated Lens page

Do you mean this page https://www.elastic.co/guide/en/kibana/master/lens.html ? What kind of content would you expect there? Do you see this as a separate section like "Add fields" or frequently asked questions?

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flash1293 Yes, I was talking about that page lens.html in the docs. I've been meaning to copy the layout of the TSVB doc, where we put reference content above the FAQ. For example, the TSVB function reference is something we could use to document the time shift feature in Lens.

@flash1293
Copy link
Contributor Author

@wylieconlon Good idea, I will prepare something like this in a separate PR

@flash1293 flash1293 merged commit c75f369 into elastic:master Jun 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 17, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 17, 2021
…egrations-to-global-search

* 'master' of github.com:elastic/kibana: (46 commits)
  [Lens] Add some more documentation for dynamic coloring (elastic#101369)
  hide not searchable results when no term (elastic#102401)
  [Lens] Fix Formula functional test with multiple suggestions (elastic#102378)
  Fix trusted apps modified by field displayed as a date field (elastic#102377)
  [Lens] Docs for time shift (elastic#102048)
  update readme of logs-metrics-ui (elastic#101968)
  Refactor observability plugin breadcrumbs (elastic#102290)
  [Index Patterns] Move rollup config to index pattern management v2 (elastic#102285)
  [Security Solution][Endpoint] Isolate Action should only be available to Platinum+ licenses (elastic#102374)
  [build] Updates Ironbank templates (elastic#102407)
  Update security best practices document (elastic#100814)
  [Enterprise Search] Set up initial KibanaPageTemplate  (elastic#102170)
  [Reporting/Docs] Add section to troubleshooting guide to explain the StatusCodeError logs (elastic#102278)
  [DOCS] Updating Elastic Security Overview topic  (elastic#101922)
  [Uptime] refactor Synthetics Integration package UI (elastic#102080)
  [Task Manager] Log at different levels based on the state (elastic#101751)
  [APM] Fixing time comparison types (elastic#101423)
  [RAC] Update alert documents in lifecycle rule type helper (elastic#101598)
  [ML] Functional tests - fix and re-activate alerting flyout test (elastic#102368)
  [Reporting] remove unused reference to path.data config (elastic#102267)
  ...

# Conflicts:
#	x-pack/plugins/fleet/kibana.json
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants