Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize alerting flyout test #102030

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[ML] Functional tests - stabilize alerting flyout test #102030

merged 1 commit into from
Jun 14, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jun 14, 2021

Summary

This PR stabilizes and re-activates the ML alerting flyout test suite.

Details

  • Similar to how we do it in other locations we don't want to check exact backend calculation results. Instead we're checking for the pattern of the expected text and validate that the number of found anomalies is > 0.
  • Also fixes the cleanup, so the test can be run multiple times in a row (before there were cases where the real-time job left something behind when just the .ml-* indices were deleted). Now, the test job (+ corresponding datafeed) is explicitly deleted.
  • Also fixes a log message, where a missing not could cause confusion.

Closes #102012

@pheyos pheyos self-assigned this Jun 14, 2021
@pheyos pheyos requested a review from a team as a code owner June 14, 2021 10:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 14, 2021
@pheyos pheyos merged commit 1501984 into elastic:master Jun 14, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2021
@pheyos @kibanamachine
[ML] Functional tests - stabilize alerting flyout test (elastic#102030)
b851a93 
This PR stabilizes and re-activates the ML alerting flyout test suite.
@kibanamachine kibanamachine mentioned this pull request Jun 14, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2021
@pheyos @kibanamachine
[ML] Functional tests - stabilize alerting flyout test (elastic#102030)
c068b77 
This PR stabilizes and re-activates the ML alerting flyout test suite.
@kibanamachine kibanamachine mentioned this pull request Jun 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 14, 2021
@kibanamachine @pheyos
[ML] Functional tests - stabilize alerting flyout test (#102030) (#10…
512777f 
…2055)

This PR stabilizes and re-activates the ML alerting flyout test suite.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 14, 2021
@kibanamachine @pheyos
[ML] Functional tests - stabilize alerting flyout test (#102030) (#10…
50f382f 
…2056)

This PR stabilizes and re-activates the ML alerting flyout test suite.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@pheyos
[ML] Functional tests - stabilize alerting flyout test (elastic#102030)
a54419c 
This PR stabilizes and re-activates the ML alerting flyout test suite.
@pheyos pheyos mentioned this pull request Jun 16, 2021
Merged
@pheyos pheyos deleted the stabilize_ml_alerting_test branch September 1, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@pheyos pheyos

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@pheyos @elasticmachine @kibanamachine @peteharverson