Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Migrated legacy Elasticsearch client for 8.0 #101850

Merged
merged 13 commits into from
Jun 30, 2021
Merged

[Monitoring] Migrated legacy Elasticsearch client for 8.0 #101850

merged 13 commits into from
Jun 30, 2021

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jun 9, 2021 •
edited
Loading

Summary

This PR migrates the legacy client to the new client per #83910 closes #102143

Checklist

@simianhacker simianhacker added Feature:Stack Monitoring v7.14.0 v8.0.0 release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 9, 2021
@jasonrhodes jasonrhodes mentioned this pull request Jun 14, 2021
Closed
74 tasks
@simianhacker simianhacker changed the title [Monitoring] Migrated legacy Elasticsearch client [Monitoring] Migrated legacy Elasticsearch client for 8.0 Jun 14, 2021
@simianhacker simianhacker added required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. and removed required-for-8.0 This work is required to be done before 8.0 lands, bc it relates to a breaking change or similar. labels Jun 14, 2021
@simianhacker simianhacker marked this pull request as ready for review June 18, 2021 01:35
@simianhacker simianhacker requested a review from a team June 18, 2021 01:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

matschaffer
matschaffer reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a typo. Looks generally good and tests pass, so happy to approve after that.

x-pack/plugins/monitoring/server/static_globals.ts Outdated Show resolved Hide resolved
matschaffer
matschaffer approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as far as my expertise goes here. Looks like the test failure should get addressed by #84440 so approving ahead of time.

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@matschaffer matschaffer mentioned this pull request Jun 24, 2021
Merged
1 task
@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
monitoring 109 2 -107

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet
Copy link
Contributor

@simianhacker is this still planned for 7.14?

@simianhacker simianhacker merged commit 25db1df into elastic:master Jun 30, 2021
@simianhacker
Copy link
Member Author

@pgayvallet yes, just merged

@simianhacker simianhacker mentioned this pull request Jun 30, 2021
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jun 30, 2021
@simianhacker
[Monitoring] Migrated legacy Elasticsearch client for 8.0 (elastic#10…
3b66b18 
…1850)
simianhacker added a commit that referenced this pull request Jun 30, 2021
@simianhacker
[Monitoring] Migrated legacy Elasticsearch client for 8.0 (#101850) (#…
92d8c4d 
…103808)
@jasonrhodes jasonrhodes mentioned this pull request Jul 7, 2021
Closed
@simianhacker simianhacker deleted the issue-83910-new-es-client-for-stack-monitoring branch April 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes left review comments

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
Feature:Stack Monitoring release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monitoring] Migrate to new Elasticsearch Client for 8.0
7 participants
@simianhacker @elasticmachine @matschaffer @kibanamachine @pgayvallet @jasonrhodes @igoristic