Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert AppServices management pages to KibanaPageTemplate #101779

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Convert AppServices management pages to KibanaPageTemplate #101779

merged 9 commits into from
Jun 15, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jun 9, 2021 •
edited
Loading

Summary

Close #101625
Tried to follow the examples as close as possible, but tabs implementation on the index patterns page is a bit different as it uses EuiTabbedContent and looks like there is no available integration with the new EuiPageHeader, so not exactly follows the example.

Search sessions

Screen Shot 2021-06-10 at 11 51 30

Reports

Screen Shot 2021-06-10 at 11 51 23

Index patterns

Screen Shot 2021-06-10 at 11 51 47
Screen Shot 2021-06-10 at 11 51 50
Screen Shot 2021-06-10 at 11 51 55
Screen Shot 2021-06-10 at 11 52 04

For maintainers

@Dosant Dosant added Feature:Data Views Data Views code and UI - index patterns before 8.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v7.14.0 v8.0.0 labels Jun 10, 2021
@Dosant Dosant changed the title convert mgmt pages Convert AppServices management pages to KibanaPageTemplate Jun 10, 2021
@Dosant Dosant marked this pull request as ready for review June 10, 2021 10:15
@Dosant Dosant requested a review from a team as a code owner June 10, 2021 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant Dosant requested review from a team, mattkime and tsullivan June 10, 2021 10:15
mattkime
mattkime approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm and appear to work well, although we should get confirmation from design that it meets their expectations.

@Dosant
Copy link
Contributor Author

Dosant commented Jun 14, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataEnhanced 159.6KB 158.9KB -707.0B
indexPatternManagement 552.8KB 550.9KB -1.9KB
reporting 33.7KB 33.1KB -605.0B
total -3.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit c409985 into elastic:master Jun 15, 2021
@Dosant Dosant mentioned this pull request Jun 15, 2021
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Jun 15, 2021
@Dosant
Convert AppServices management pages to KibanaPageTemplate (elastic#1…
0e35536 
…01779)
@cchaos cchaos mentioned this pull request Jun 15, 2021
Closed
16 tasks
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@Dosant
Convert AppServices management pages to KibanaPageTemplate (elastic#1…
f9fac2e 
…01779)
Dosant added a commit that referenced this pull request Jun 16, 2021
@Dosant @kibanamachine
Convert AppServices management pages to KibanaPageTemplate (#101779) (#…
eeca5d2 
…102224)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

@myasonik myasonik myasonik approved these changes

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert search sessions and index patterns to new management layout
5 participants
@Dosant @elasticmachine @kibanamachine @mattkime @myasonik