Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Move Index Data Visualizer into separate plugin (Part 1) (#100922) #101665

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jun 8, 2021

Backports the following commits to 7.x:

@qn895 qn895 added the backport label Jun 8, 2021
@qn895 qn895 enabled auto-merge (squash) June 8, 2021 20:08
@qn895 qn895 disabled auto-merge June 8, 2021 20:08
@qn895 qn895 enabled auto-merge (squash) June 9, 2021 19:56
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataVisualizer - 236 +236
fileDataVisualizer 181 - -181
ml 1759 1691 -68
total -13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataVisualizer - 59 +59
fileDataVisualizer 19 - -19
total +40

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
dataVisualizer - 1 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer - 1.1MB ⚠️ +1.1MB
fileDataVisualizer 1.0MB - -1.0MB
ml 5.9MB 5.8MB -118.2KB
total -21.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer - 13.6KB +13.6KB
fileDataVisualizer 12.7KB - -12.7KB
ml 67.1KB 66.8KB -255.0B
total +651.0B
Unknown metric groups

API count

id before after diff
dataVisualizer - 59 +59
fileDataVisualizer 19 - -19
total +40

async chunk count

id before after diff
dataVisualizer - 2 +2
fileDataVisualizer 2 - -2
total -0

References to deprecated APIs

id before after diff
ml 121 99 -22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit 0d4edb2 into elastic:7.x Jun 9, 2021
@qn895 qn895 deleted the backport/7.x/pr-100922 branch June 15, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants