Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for role specific access to non-default space #101653

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jun 8, 2021

This addition is expanding x-pack/test/functional/apps/spaces/feature_controls/spaces_security.ts test to ensure role-specific access to non-default space works fine

@bhavyarm bhavyarm self-assigned this Jun 8, 2021
@bhavyarm bhavyarm added v8.0.0 v7.14.0 Feature:Security/Spaces Platform Security - Spaces feature Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes labels Jun 8, 2021
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jun 8, 2021

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review June 8, 2021 20:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm requested a review from LeeDr June 8, 2021 20:44
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and Jenkins results

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jun 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Security/Spaces Platform Security - Spaces feature release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants