[Security Solution][Timeline] Fix User not able to scroll down and access Alert table on adding long content in Timeline's Description #101486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@monina-n, could you take a look and let me know if my solution makes sense and how many lines we shall truncate the description on the "Timelines list"? |
machadoum
added
7.14 candidate
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
cnasikas
reviewed
Jun 14, 2021
x-pack/plugins/security_solution/public/common/components/line_clamp/index.tsx
Outdated
Show resolved
Hide resolved
machadoum
changed the title
machadoum
force-pushed
the
siem-timeline-issue-100259
branch
from
2b59d32
to
813e073
Compare
machadoum
force-pushed
the
siem-timeline-issue-100259
branch
from
813e073
to
c0599fb
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
cnasikas
approved these changes
Jun 16, 2021
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Jun 16, 2021
…cess Alert table on adding long content in Timeline's Description (elastic#101486) * Add LineClamp component to timeline description * Truncate timeline description on timeline table * Fix StyledLineClamp styled component performance issue Read more: https://styled-components.com/docs/faqs#why-should-i-avoid-declaring-styled-components-in-the-render-method
machadoum
added a commit
that referenced
this pull request
Jun 16, 2021
…cess Alert table on adding long content in Timeline's Description (#101486) (#102301) * Add LineClamp component to timeline description * Truncate timeline description on timeline table * Fix StyledLineClamp styled component performance issue Read more: https://styled-components.com/docs/faqs#why-should-i-avoid-declaring-styled-components-in-the-render-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue: #100259
1. Open timeline page
When the timeline description is too big, it takes too much space leaving almost no room for the list of events.
To solve this problem I reused the component that is used to collapse the Event description.
After change:
Initial state (collapsed)
Expanded
2. Timelines page
A long description also affects the "Timelines page", where the description cell takes too much space.
To solve this second problem, we are truncating the content in 5 lines.
After change
Checklist