Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix newsfeed unread notifications always on when reloading Kibana (#100357) #101163

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

…astic#100357)

* fix the implementation

* add unit tests

* add API unit tests

* fix public interface

* address review comments

* name convertItem to localizeItem

* use fetch instead of core.http and add tests
@pgayvallet pgayvallet enabled auto-merge (squash) June 2, 2021 14:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
newsfeed 16 14 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
newsfeed 19.0KB 18.1KB -959.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 0c57d8d into elastic:7.x Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants