Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a description field for spymode #10078

Closed
wants to merge 2 commits into from

Conversation

mustafatok
Copy link

@mustafatok mustafatok commented Jan 26, 2017

Current description field only keeps the information for creating the visualization. I added another field in vis.params to display specific description for each visualization. Closes #2538.

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@epixa
Copy link
Contributor

epixa commented Jan 26, 2017

jenkins, test this

@epixa epixa added the review label Jan 26, 2017
@epixa epixa changed the title Added a description field for spymode. Closes#2538 Added a description field for spymode Jan 26, 2017
@epixa epixa added the :Sharing label Jan 26, 2017
@tbragin
Copy link
Contributor

tbragin commented Feb 7, 2017

@mustafatok Could you add a screenshot of user-facing impact of this change? Where in the UI does this description show up?

@tbragin tbragin added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) and removed :Sharing labels Feb 21, 2017
@thomasneirynck thomasneirynck self-assigned this Feb 21, 2017
@ppisljar
Copy link
Member

closing due to no response from author

@ppisljar ppisljar closed this Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) feedback_needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants