Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Replace legacy es client usage in category examples #100716

Merged
merged 3 commits into from
Jun 1, 2021
Merged

[Logs UI] Replace legacy es client usage in category examples #100716

merged 3 commits into from
Jun 1, 2021

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented May 26, 2021 •
edited
Loading

📝 Summary

This replace the usage of the deprecated legacy Elasticsearch client with the new Elasticsearch client in the log category examples library functions.

closes #73978

🕵️ Review notes

From the user's perspective nothing should change visually.

@weltenwort weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 26, 2021
@weltenwort weltenwort added this to the Logs UI 7.14 milestone May 26, 2021
@weltenwort weltenwort self-assigned this May 26, 2021
@weltenwort weltenwort changed the title Replace legacy es client usage in category examples [Logs UI] Replace legacy es client usage in category examples May 26, 2021
@weltenwort weltenwort marked this pull request as ready for review May 26, 2021 19:58
@weltenwort weltenwort requested a review from a team as a code owner May 26, 2021 19:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

Kerry350
Kerry350 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🎉

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 146 -115
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -345

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort merged commit 61a49c6 into elastic:master Jun 1, 2021
@weltenwort weltenwort deleted the logs-ui-remove-legacy-es-client branch June 1, 2021 13:48
@kibanamachine kibanamachine mentioned this pull request Jun 1, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 1, 2021
@weltenwort @kibanamachine
[Logs UI] Replace legacy es client usage in category examples (elasti…
b6403a2 
…c#100716)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 1, 2021
@kibanamachine @weltenwort
[Logs UI] Replace legacy es client usage in category examples (#100716)…
f7b99c2 
… (#101055)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@weltenwort weltenwort

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.14
Development

Successfully merging this pull request may close these issues.

[Logs UI] Replace legacy elasticsearch client usage
4 participants
@weltenwort @elasticmachine @kibanamachine @Kerry350