Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CTI] Adds Threat Intel dashboard links to Overview page #100423
[CTI] Adds Threat Intel dashboard links to Overview page #100423
Changes from 2 commits
32afd68
1fac228
929fdfb
42f4aec
cff1557
9158563
c4bb293
fb57edf
40c278d
a137105
989fc56
0940db9
80e8483
2d4d1fd
f4dba26
797c0ab
114253d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing an empty query and checking the format of the dataset value (which may not always conform to this structure), I think it'll be more accurate and simpler to query instead for
event.kind: 'indicator'
, which should guarantee that we're only dealing with indicator data.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate 😦 ;
fileset.name
contains the unscoped version of this value but that's very filebeat specific.@P1llus is there a strong reason for prefixing
event.dataset
values withthreatintel.
? That seems somewhat redundant withevent.module: 'threatintel'
. If not, could we perhaps update that for this 7.14?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This topic is still in discussion on multiple places, so I don't know, as one would be removed in packages. So we would have to put this on hold at least for another few days.