Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GS] Make tag search case insensitive #85584

Closed
ryankeairns opened this issue Dec 10, 2020 · 1 comment · Fixed by #183092
Closed

[GS] Make tag search case insensitive #85584

ryankeairns opened this issue Dec 10, 2020 · 1 comment · Fixed by #183092
Assignees
@rshen91
Labels
bug Fixes for quality problems that affect the customer experience Feature:Navigational Search Global search bar Feature:Saved Object Tagging Saved Objects Tagging feature Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@ryankeairns
Copy link
Contributor

The only little hiccup I'm seeing now is that the tags seem to be case sensitive. I thought Pierre addressed this in his PR, so perhaps this is just out of date? For example, I have a Red tag, but typing tag:red returns no results (and no suggestion).

Actually it doesn't, even on master.

What I did is that if you have a Red tag and you type red, the tag:red suggestion will be displayed.

However, the logic retrieving tags by their name always was case sensitive. So tag:red will not 'find' the Red tag. I think we do need to fix that, but this was not introduced by @myasonik's PR.

Originally posted by @pgayvallet in #85084 (comment)
@ryankeairns ryankeairns added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@ryankeairns ryankeairns added the Feature:Header Work related to the header section of the Kibana app. label Dec 10, 2020
@pgayvallet pgayvallet added the Feature:Saved Object Tagging Saved Objects Tagging feature label Dec 10, 2020
@afharo afharo added Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Feature:Header Work related to the header section of the Kibana app. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 16, 2022
@petrklapka petrklapka added the bug Fixes for quality problems that affect the customer experience label Feb 8, 2024
@rshen91 rshen91 self-assigned this May 2, 2024
@rshen91 rshen91 mentioned this issue May 9, 2024
Merged
1 task
rshen91 added a commit that referenced this issue May 14, 2024
@rshen91
[Global Search] Fix case sensitivity tag search (#183092)
cd64be8 
## Summary

Closes #85584

Tags cannot be created that are the same name, even if uppercase or
lowercase. This PR fixes the issue where global search did not recognize
tag:U vs tag:u and will provide suggestions if either uppercase or lower
case tag name is provided.

<img width="1078" alt="Screenshot 2024-05-09 at 1 57 38 PM"
src="https://github.com/elastic/kibana/assets/20343860/22ec513e-2245-4d1c-84f2-26032d0d7aa6">
<img width="1091" alt="Screenshot 2024-05-09 at 1 57 46 PM"
src="https://github.com/elastic/kibana/assets/20343860/09d2f530-eba6-47b5-890a-b652d33b6b2a">

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
bug Fixes for quality problems that affect the customer experience Feature:Navigational Search Global search bar Feature:Saved Object Tagging Saved Objects Tagging feature Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Global Search] Fix case sensitivity tag search rshen91/kibana
6 participants
@ryankeairns @pgayvallet @afharo @elasticmachine @rshen91 @petrklapka