Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher level of details for parsing error in CSV import #7647

Closed
bahaaldine opened this issue Jul 6, 2016 · 6 comments
Closed

Higher level of details for parsing error in CSV import #7647

bahaaldine opened this issue Jul 6, 2016 · 6 comments
Labels
Feature:Add Data Add Data and sample data feature on Home release_note:enhancement

Comments

@bahaaldine
Copy link

The current level of details a user get for parsing error does not allow for debugging:

Could be good to have at least the field and the related parsing error details.

capture d ecran 2016-07-06 a 20 30 33

@Bargs
Copy link
Contributor

Bargs commented Jul 6, 2016

The field name should be included. Could you provide the CSV you're using and a screen shot of the type mapping step?

@bahaaldine
Copy link
Author

@Bargs here is the file I'm using:

https://drive.google.com/open?id=0B2nTr5APsKxcbjNLMm52M0RySTg

Here is the mapping screenshot:

mapping

This is the parsing error output:

capture d ecran 2016-07-07 a 10 24 22

With +13000 lines displayed in the list (#7648)

capture d ecran 2016-07-07 a 10 24 38

@Bargs
Copy link
Contributor

Bargs commented Jul 7, 2016

@bahaaldine those output screenshots look different than the one in your original post, in this case it's correctly identifying timestamp as the problem field. Do you have any idea what happened in your original screenshot?

@bahaaldine
Copy link
Author

@Bargs that's true and I don't know how I got the first screenshot, and I can't reproduce it.

My point for this issue is:

  • The field name is indeed included, but the user doesn't why there was an error. I think it's necessary to have the parse exception detail.
  • Only one field name is actually shown up, here related test:
    • I've first tried to import the same CSV by setting the Date to a date type:

only-date-field

  • and this is what I have:

capture d ecran 2016-07-08 a 11 40 19

So far so good.

  • When I try to set both timestamp and Date to date

both-fields

  • This is what I got

capture d ecran 2016-07-08 a 11 41 05

  • Only timestamp is displayed in the error, even if I go through all the +13K lines, Date is never displayed.

@bahaaldine bahaaldine added the Feature:Add Data Add Data and sample data feature on Home label Jul 8, 2016
@Bargs
Copy link
Contributor

Bargs commented Jul 8, 2016

Hmmm yeah that does stink. I wonder if Elasticsearch returns both errors, or if I'm only getting timestamp back. I'll have to check.

The field name is indeed included, but the user doesn't why there was an error. I think it's necessary to have the parse exception detail.

Could you add your thoughts on that to this ticket #7632? I'm not sure yet what the perfect error message looks like. For some users the full Elasticsearch error info might be overwhelming, but as you mentioned other users are just gonna want to see the full details from ES.

@epixa
Copy link
Contributor

epixa commented Dec 26, 2016

I'm going to close this since CSV upload was pulled. We can always refer back to this issue if/when we revisit the feature.

@epixa epixa closed this as completed Dec 26, 2016
e40pud added a commit to e40pud/kibana that referenced this issue Sep 14, 2023
e40pud added a commit to e40pud/kibana that referenced this issue Sep 20, 2023
e40pud added a commit to e40pud/kibana that referenced this issue Sep 20, 2023
e40pud added a commit that referenced this issue Sep 22, 2023
…he list of assigned users (#7647) (#166845)

## Summary

Closes elastic/security-team#7647

This PR extends alert's schema. We add a new field
`kibana.alert.workflow_assignee_ids` where assignees will live.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Add Data Add Data and sample data feature on Home release_note:enhancement
Projects
None yet
Development

No branches or pull requests

4 participants