Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped Flaky detection engine tests need re-enabled #71814

Closed
tylersmalley opened this issue Jul 15, 2020 · 4 comments
Closed

Skipped Flaky detection engine tests need re-enabled #71814

tylersmalley opened this issue Jul 15, 2020 · 4 comments
Assignees
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0

Comments

@tylersmalley
Copy link
Contributor

There is no automated issue yet, as this has not failed on a tracked branch but we're seeing widespread failures for it on PR's.

detection engine api security and spaces enabled add_prepackaged_rules creating prepackaged rules should be possible to call the API twice and the second time the number of rules installed should be zero

image

There is also a related failure in alerts_detection_rules_prebuilt.spec.ts.

@andrew-goldstein encountered both these failures on his PR: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/61797/flowGraphTable/

@tylersmalley tylersmalley added blocker failed-test A test failure on a tracked branch, potentially flaky-test Team:SIEM v8.0.0 v7.9.0 labels Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

tylersmalley pushed a commit that referenced this issue Jul 15, 2020
#71814

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this issue Jul 15, 2020
#71814

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

master/8.0: ddbfe53
7.x/7.9: 65c0dab

@spalger
Copy link
Contributor

spalger commented Jul 15, 2020

Moving to automated test failure issue created #71867

@spalger spalger closed this as completed Jul 15, 2020
FrankHassanabad added a commit that referenced this issue Jul 20, 2020
…tFor() and un-skips the tests (#72479)

## Summary

* Utilizes the `waitFor` so that the tests are less flaky and more resilient
* Unskips a test that was due to a regression within Elastic Search that should be fixed now
* #71867
* #71814
* #71612

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this issue Jul 20, 2020
…tFor() and un-skips the tests (elastic#72479)

## Summary

* Utilizes the `waitFor` so that the tests are less flaky and more resilient
* Unskips a test that was due to a regression within Elastic Search that should be fixed now
* elastic#71867
* elastic#71814
* elastic#71612

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this issue Jul 20, 2020
…tFor() and un-skips the tests (elastic#72479)

## Summary

* Utilizes the `waitFor` so that the tests are less flaky and more resilient
* Unskips a test that was due to a regression within Elastic Search that should be fixed now
* elastic#71867
* elastic#71814
* elastic#71612

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad added a commit that referenced this issue Jul 20, 2020
…tFor() and un-skips the tests (#72479) (#72508)

## Summary

* Utilizes the `waitFor` so that the tests are less flaky and more resilient
* Unskips a test that was due to a regression within Elastic Search that should be fixed now
* #71867
* #71814
* #71612

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad added a commit that referenced this issue Jul 20, 2020
…tFor() and un-skips the tests (#72479) (#72507)

## Summary

* Utilizes the `waitFor` so that the tests are less flaky and more resilient
* Unskips a test that was due to a regression within Elastic Search that should be fixed now
* #71867
* #71814
* #71612

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
@FrankHassanabad FrankHassanabad self-assigned this Jul 21, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

5 participants