Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Node keeps changing position until it's finally set on the page 🤯 #66528

Closed
cauemarcondes opened this issue May 14, 2020 · 0 comments · Fixed by #66625
Closed

[APM] Node keeps changing position until it's finally set on the page 🤯 #66528

cauemarcondes opened this issue May 14, 2020 · 0 comments · Fixed by #66625
Assignees
@smith
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.8.0

Comments

@cauemarcondes
Copy link
Contributor

When you open the service map by clicking on its tab, sometimes the node keeps changing its position until it's finally set in the correct place.

maps.gif
@cauemarcondes cauemarcondes added [zube]: (7.8) Planned for release bug Fixes for quality problems that affect the customer experience apm:service-maps Service Map feature in APM v7.8.0 labels May 14, 2020
@smith smith self-assigned this May 14, 2020
smith added a commit to smith/kibana that referenced this issue May 14, 2020
@smith
[APM] Don't trigger map layout if no elements
81a769f 
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
@smith smith mentioned this issue May 14, 2020
Merged
smith added a commit that referenced this issue May 14, 2020
@smith
[APM] Don't trigger map layout if no elements (#66625)
a54de76 
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
smith added a commit to smith/kibana that referenced this issue May 14, 2020
@smith
[APM] Don't trigger map layout if no elements (elastic#66625)
4a6811a 
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
smith added a commit to smith/kibana that referenced this issue May 14, 2020
@smith
[APM] Don't trigger map layout if no elements (elastic#66625)
2ae6a78 
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
smith added a commit that referenced this issue May 15, 2020
@smith
[APM] Don't trigger map layout if no elements (#66625) (#66653)
3f6811e 
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
smith added a commit that referenced this issue May 15, 2020
@smith
[APM] Don't trigger map layout if no elements (#66625) (#66652)
92dd01e 
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Don't trigger map layout if no elements smith/kibana
3 participants
@smith @sorenlouv @cauemarcondes