Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Management] Data Streams without a package should be empty #66461

Closed
ruflin opened this issue May 13, 2020 · 4 comments · Fixed by #66606
Closed

[Ingest Management] Data Streams without a package should be empty #66461

ruflin opened this issue May 13, 2020 · 4 comments · Fixed by #66606
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ruflin
Copy link
Member

ruflin commented May 13, 2020

Not all data streams have a related package. Currently we extract the package name from the dataset but instead we should match dataset names with the datasets inside the packages. Data Streams that do not related to a package should not list one. In the screenshot below, agent should be empty.

Screenshot 2020-05-13 at 21 34 30

@ruflin ruflin added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang added the bug Fixes for quality problems that affect the customer experience label May 13, 2020
@jen-huang jen-huang self-assigned this May 14, 2020
@ruflin
Copy link
Member Author

ruflin commented May 18, 2020

@jen-huang What you have in #66606 is a fix for all the cases where we can extract it from the dataset name. There will be dataset without an . in the name like logs-endpoint-*. What I would like to see implemented long term is that we get information about which packages expose which datasets and based on this create the links instead of trying to guess it from the name.

Going to reopen this issue but can also file a new one @jen-huang if you think it would be better.

@ruflin ruflin reopened this May 18, 2020
@jen-huang
Copy link
Contributor

jen-huang commented May 18, 2020

@ruflin Datasets without . will just return the entire dataset name (i.e. "endpoint".split('.')[0] === 'endpoint') so the workaround code still works in that case.

I think a new issue would be better to track the work needed to remove the workaround with the proper way you describe.

@ruflin
Copy link
Member Author

ruflin commented May 18, 2020

Will file a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants