Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM UI] Bug: Docs link by the metadata tabs shows "children" label instead of the actual label #59128

Closed
formgeist opened this issue Mar 3, 2020 · 1 comment · Fixed by #59518
Closed

[APM UI] Bug: Docs link by the metadata tabs shows "children" label instead of the actual label #59128

formgeist opened this issue Mar 3, 2020 · 1 comment · Fixed by #59518
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.7.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Mar 3, 2020 •
edited by sorenlouv
Loading

Kibana version:

Master

Elasticsearch version:

Master

Describe the bug:

Screenshot 2020-03-03 at 11 49 55

In all of the placements where we have a link to the metadata documentation, the button label says "children".

Steps to reproduce:

  1. Go to Transaction detail page for any transaction and go to the metadata tab. The same goes for transaction and span detail flyouts

Expected behavior:

The button should show the actual button label "How to add labels and other data".

Technical details

Add brackets around children in:

kibana/x-pack/legacy/plugins/apm/public/components/shared/Links/ElasticDocsLink.tsx

Lines 25 to 27 in c3f8647

<EuiLink href={href} {...rest}>
children
</EuiLink>

A test should be added for ElasticDocsLink to avoid this happening again.
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Mar 6, 2020
smith added a commit to smith/kibana that referenced this issue Mar 6, 2020
@smith
Empty message for APM service map
79b562d 
When only one node is displayed, show an empty message.

Also:

* Start adding a basic Jest test for the ServiceMap component
* Fix bug where EuiDocsLink was rendering "children" instead of the actual children

Closes elastic#59326.
Closes elastic#59128.
@smith smith mentioned this issue Mar 6, 2020
Merged
smith added a commit that referenced this issue Mar 6, 2020
@smith
Empty message for APM service map (#59518)
0d3dd97 
When only one node is displayed, show an empty message.

Also:

* Start adding a basic Jest test for the ServiceMap component
* Fix bug where EuiDocsLink was rendering "children" instead of the actual children

Closes #59326.
Closes #59128.
smith added a commit to smith/kibana that referenced this issue Mar 6, 2020
@smith
Empty message for APM service map (elastic#59518)
65c7d4b 
When only one node is displayed, show an empty message.

Also:

* Start adding a basic Jest test for the ServiceMap component
* Fix bug where EuiDocsLink was rendering "children" instead of the actual children

Closes elastic#59326.
Closes elastic#59128.
smith added a commit to smith/kibana that referenced this issue Mar 9, 2020
@smith
Empty message for APM service map (elastic#59518)
ac2334e 
When only one node is displayed, show an empty message.

Also:

* Start adding a basic Jest test for the ServiceMap component
* Fix bug where EuiDocsLink was rendering "children" instead of the actual children

Closes elastic#59326.
Closes elastic#59128.
smith added a commit that referenced this issue Mar 9, 2020
@smith
Empty message for APM service map (#59518) (#59677)
e72d479 
When only one node is displayed, show an empty message.

Also:

* Start adding a basic Jest test for the ServiceMap component
* Fix bug where EuiDocsLink was rendering "children" instead of the actual children

Closes #59326.
Closes #59128.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Empty message for APM service map smith/kibana
5 participants
@smith @sorenlouv @cjcenizal @formgeist @elasticmachine