Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tutorial resources #55710

Closed
flash1293 opened this issue Jan 23, 2020 · 2 comments · Fixed by #64298
Closed

Migrate tutorial resources #55710

flash1293 opened this issue Jan 23, 2020 · 2 comments · Fixed by #64298
Assignees
@DianaDerevyankina
Labels
Feature:Home Kibana home application Feature:NP Migration REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 23, 2020 •
edited
Loading

The tutorial resources (https://github.com/elastic/kibana/tree/58d4e71b1c95000009ae768729eab1811e96d20f/src/legacy/core_plugins/kibana/public/home) are currently served from the legacy platform. Once #50654 is merged, those can also move into the server part of the home plugin.

Blocked on platform right now.

Edit: Seems like #60490 is enough to complete this task:

Kibana platform serves plugin static assets from the my_plugin/public/assets folder. No additional configuration is required.

The assets for tutorials should be moved into home/public/assets, paths adjusted accordingly.
Apm assets should be moved into the apm plugin, ems assets should be moved into the maps plugin.
@flash1293 flash1293 added Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Jan 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added REASSIGN from Team:Core UI Deprecated label for old Core UI team and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@DianaDerevyankina DianaDerevyankina self-assigned this Apr 21, 2020
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue Apr 23, 2020
@DianaDerevyankina
Migrate tutorial resources
b547861 
Closes elastic#55710
@DianaDerevyankina DianaDerevyankina mentioned this issue Apr 23, 2020
Merged
7 tasks
DianaDerevyankina added a commit that referenced this issue May 4, 2020
@DianaDerevyankina @elasticmachine
Migrate tutorial resources (#64298)
a854a1d 
* Migrate tutorial resources

Closes #55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 4, 2020
@DianaDerevyankina @elasticmachine
Migrate tutorial resources (elastic#64298)
9bd5b1c 
* Migrate tutorial resources

Closes elastic#55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 5, 2020
@DianaDerevyankina @elasticmachine
Migrate tutorial resources (elastic#64298)
9c05c82 
* Migrate tutorial resources

Closes elastic#55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit that referenced this issue May 5, 2020
@DianaDerevyankina @elasticmachine
Migrate tutorial resources (#64298) (#65231)
f1730b1 
* Migrate tutorial resources

Closes #55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit that referenced this issue May 7, 2020
@DianaDerevyankina @elasticmachine
Move remaining home assets to the new platform (#65053)
e723a8f 
* Migrate tutorial resources

Closes #55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

* Move assets and sample_data_resources, update snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 7, 2020
@DianaDerevyankina @elasticmachine
Move remaining home assets to the new platform (elastic#65053)
f1a6434 
* Migrate tutorial resources

Closes elastic#55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

* Move assets and sample_data_resources, update snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
DianaDerevyankina added a commit that referenced this issue May 8, 2020
@DianaDerevyankina @elasticmachine
Move remaining home assets to the new platform (#65053) (#65653)
c9b5e21 
* Migrate tutorial resources

Closes #55710

* Added type to context in apm plugin index

* Removed context parameter  from ApmPlugin

* Generated apm plugin by generate_plugin script

* Removed getGreeting declaration

* Remove unused assets and comment previewImagePaths

* Removed unnecessary types file

* Move assets and sample_data_resources, update snapshot

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:Home Kibana home application Feature:NP Migration REASSIGN from Team:Core UI Deprecated label for old Core UI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate tutorial resources DianaDerevyankina/kibana
4 participants
@timroes @flash1293 @elasticmachine @DianaDerevyankina