[APM] 404 Not found when Error Group Id has special characters in synthtrace scenarios #209096
Assignees
Labels
apm:synthtrace
APM Synthtrace Topics
apm
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
rmyz
added
apm
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
smith
added
the
bug
|
I have been debugging with @kpatticha, and this error is only related to Synthtrace, will investigate why it is not creating the error group id as a number. We are safe as this does not impact our customers. |
rmyz
changed the title
This was referenced Feb 5, 2025
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 7, 2025
…10010) ## Summary Closes elastic#209096 (cherry picked from commit ba5ae97)
kibanamachine
added a commit
that referenced
this issue
Feb 7, 2025
…0010) (#210230) # Backport This will backport the following commits from `main` to `9.0`: - [[Synthtrace] Sanitize default value for error grouping key (#210010)](#210010) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-02-07T17:13:11Z","message":"[Synthtrace] Sanitize default value for error grouping key (#210010)\n\n## Summary\n\nCloses #209096","sha":"ba5ae97569e59b83d6748bd0a8a5b52b573fda07","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","apm","backport:prev-minor","apm:synthtrace","ci:project-deploy-observability","Team:obs-ux-infra_services","v9.1.0"],"title":"[Synthtrace] Sanitize default value for error grouping key","number":210010,"url":"https://github.com/elastic/kibana/pull/210010","mergeCommit":{"message":"[Synthtrace] Sanitize default value for error grouping key (#210010)\n\n## Summary\n\nCloses #209096","sha":"ba5ae97569e59b83d6748bd0a8a5b52b573fda07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210010","number":210010,"mergeCommit":{"message":"[Synthtrace] Sanitize default value for error grouping key (#210010)\n\n## Summary\n\nCloses #209096","sha":"ba5ae97569e59b83d6748bd0a8a5b52b573fda07"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this issue
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
We have a bug when a synthtrace service has error group ids that contain special characters, for example
No handler for GET /order/{id}.As the way we create links is to append the errorGroupId into the URL, as it's not encoded, it will end up having a route like
/services/Titus-java-1994/errors/00No handler for GET /order/{id}, the router can't match a route to this path, so it returns a 404.Technical context
We had a function that calculated the error.grouping_key but the implementation changed to rely on APMError constructor and is using generateLongId which ends up having an
error.grouping_keylike00No handler for GET /order/{id}for the errorNo handler for GET /order/{id}, which is wrong.AC
The text was updated successfully, but these errors were encountered: