Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Heatmap] Add functional test to label rotation #206053

Closed
mariairiartef opened this issue Jan 9, 2025 · 1 comment · Fixed by #208751
Closed

[Lens][Heatmap] Add functional test to label rotation #206053

mariairiartef opened this issue Jan 9, 2025 · 1 comment · Fixed by #208751
Assignees
@mariairiartef
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure test

Comments

@mariairiartef
Copy link
Contributor

In the PR #202143, we were unable to test if the rotation change in the label was applied. To address this, we have opened an issue to add this additional information to the debug state: elastic/elastic-charts#2578. Once this is addressed, we will be able to add functional tests.
@mariairiartef mariairiartef added Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure test labels Jan 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mariairiartef mariairiartef changed the title [lens][heatmap] Add functional test to label rotation [Lens][Heatmap] Add functional test to label rotation Jan 9, 2025
@mariairiartef mariairiartef mentioned this issue Jan 9, 2025
Merged
3 tasks
This was referenced Jan 23, 2025
Merged
Merged
@mariairiartef mariairiartef self-assigned this Feb 5, 2025
mariairiartef added a commit that referenced this issue Feb 12, 2025
@mariairiartef
[Lens] Add functional test case for heatmap x-axis label rotation (#2…
c4ecd0d 
…08751)

## Summary

Closes #206053


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 12, 2025
@mariairiartef
[Lens] Add functional test case for heatmap x-axis label rotation (el…
d9a14c8 
…astic#208751)

## Summary

Closes elastic#206053

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit c4ecd0d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 12, 2025
@mariairiartef
[Lens] Add functional test case for heatmap x-axis label rotation (el…
9440e3e 
…astic#208751)

## Summary

Closes elastic#206053

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit c4ecd0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariairiartef mariairiartef

Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Add functional test case for heatmap x-axis label rotation mariairiartef/kibana
2 participants
@elasticmachine @mariairiartef