-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] JS warnings when opening the document flyout in Discover #202287
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
For me it seems the first error is coming from EuiPaginantion? |
So, the tabindex Error is very easy to fix, just needs to be changed here: kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_flyout/use_flyout_a11y.tsx Line 40 in 0ac6965
the unique "key" prop is the opposite. when removing the pagination of the DocViewer it's gone ... but this can't be the solution of course, there might be some problem in the EUI component surfacing in this context kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_flyout/doc_viewer_flyout.tsx Lines 284 to 293 in 0ac6965
|
@jughosta confirmed , each child in a list should have a unique "key" prop is coming from |
from our end @elastic/kibana-data-discovery , fixing the |
@gbamparop @kertal I went ahead and created an issue for the key warning in EUI: |
Thx @weronikaolejniczak , one update, I can't reproduce in index management for whatever reason ... my guess is that it's surfacing in Discover, because there's Anyway the other error |
@kertal quick status update: I figured the error is coming from I could also make a PR for the |
@acstll my guess is .. there's some Sure thing, your help is very welcome, and it's a nice first issue to get your feet wet in Kibana code! I'll assign this issue to you 👍 |
I was not able to reproduce the error outside Kibana, nor determine the real cause of it, see elastic/kibana#202287
I was not able to reproduce the error outside Kibana, nor determine the real cause of it, see elastic/kibana#202287
Fixes one of the errors described in #202287 — namely a console warning due to invalid DOM property.
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property. (cherry picked from commit 59826cc)
I was not able to reproduce the error outside Kibana, nor determine the real cause of it, see elastic/kibana#202287
… (#204605) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Fix console warning for invalid DOM property (#204417)](#204417) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Arturo Castillo Delgado","email":"arturo.castillo@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T15:49:36Z","message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDocViewer"],"title":"[Discover] Fix console warning for invalid DOM property","number":204417,"url":"https://github.com/elastic/kibana/pull/204417","mergeCommit":{"message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204417","number":204417,"mergeCommit":{"message":"[Discover] Fix console warning for invalid DOM property (#204417)\n\nFixes one of the errors described in #202287 — namely a console warning\r\ndue to invalid DOM property.","sha":"59826ccdb55775261d2255d1483c40b3fbf60a21"}}]}] BACKPORT--> Co-authored-by: Arturo Castillo Delgado <arturo.castillo@elastic.co>
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property.
Fixes one of the errors described in elastic#202287 — namely a console warning due to invalid DOM property.
I was not able to reproduce the error outside Kibana, nor determine the real cause of it, see elastic/kibana#202287
When opening the document flyout in Discover, the following warnings are displayed in the Console while running Kibana locally on the
main
branch.The stack traces can be found below:
Warning: Each child in a list should have a unique "key" prop
Invalid DOM property `tabindex`. Did you mean `tabIndex`?
The text was updated successfully, but these errors were encountered: