Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Clean up enablePackagesStateMachine and related code #189383

Closed
2 tasks
criamico opened this issue Jul 29, 2024 · 3 comments · Fixed by #191052
Closed
2 tasks

[Fleet] Clean up enablePackagesStateMachine and related code #189383

criamico opened this issue Jul 29, 2024 · 3 comments · Fixed by #191052
Assignees
@criamico
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@criamico
Copy link
Contributor

criamico commented Jul 29, 2024 •
edited
Loading

With 8.14.0 a new #175592 to install packages was introduced, but it was only enabled in install by registry and put under feature flag enablePackagesStateMachine.

  • Clean up feature flag enablePackagesStateMachine
  • Once all the paths that use installPackageCommon are switched to the new state machine, this old code can be removed as well.
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico mentioned this issue Jul 29, 2024
Open
@juliaElastic
Copy link
Contributor

Should we add a task to remove the feature flag as well?

@criamico
Copy link
Contributor Author

criamico commented Jul 30, 2024 •
edited
Loading

Should we add a task to remove the feature flag as well?

@juliaElastic Yes I intended to remove the feature flag as first thing, I rephrased the description.

@criamico criamico mentioned this issue Aug 22, 2024
Merged
1 task
criamico added a commit that referenced this issue Aug 26, 2024
@criamico @elasticmachine
[Fleet] Clean up feature flag enablePackagesStateMachine (#191052)
b2d0846 
Closes #189383

## Summary

In 8.14.0 we added and enabled feature flag
`enablePackagesStateMachine`. This PR cleans it up as it's been enabled
since then and we don't need it anymore. Also removing related test
cases.

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Clean up feature flag enablePackagesStateMachine criamico/kibana
3 participants
@elasticmachine @criamico @juliaElastic