Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serverless projectId to cloud plugin's configuration #161652

Closed
pgayvallet opened this issue Jul 11, 2023 · 1 comment · Fixed by #161728
Closed

Add serverless projectId to cloud plugin's configuration #161652

pgayvallet opened this issue Jul 11, 2023 · 1 comment · Fixed by #161728
Assignees
@pgayvallet
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 11, 2023 •
edited
Loading

We need to add the projectId to the cloud plugin's config, and populate if from serverless deployments.

We could probably add a new serverless subdomain to cloud's config.

Proposed config path: xpack.cloud.serverless.projectId

This is required to be done first to allow the equivalent change on Cloud's side to inject the value
@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jul 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet self-assigned this Jul 11, 2023
@pgayvallet pgayvallet mentioned this issue Jul 12, 2023
Merged
pgayvallet added a commit that referenced this issue Jul 14, 2023
@pgayvallet
[cloud plugin] Add serverless projectId to configuration and contract (…
a9786df 
…#161728)

## Summary

Fix #161652

Add the `serverless.projectId` config setting to the `cloud` plugin, and
expose the `isCloudServerless` and `serverless.projectId` info from the
cloud plugin's API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cloud plugin] Add serverless projectId to configuration and contract pgayvallet/kibana
2 participants
@pgayvallet @elasticmachine