Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Make the custom equation option the default and only option for the Threshold rule param #159326

Closed
fkanout opened this issue Jun 8, 2023 · 1 comment · Fixed by #158665
Closed

[AO] Make the custom equation option the default and only option for the Threshold rule param #159326

fkanout opened this issue Jun 8, 2023 · 1 comment · Fixed by #158665
Assignees
@fkanout
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Jun 8, 2023 •
edited
Loading

📝 Summary

Part of https://github.com/elastic/actionable-observability/issues/36

In the v8.9 scope, the Threshold rule should make custom equation the only option in the rule params.

Screenshot 2023-06-08 at 17 41 17

✅ ACs

  • Make the custom equation option the default and only option
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout self-assigned this Jun 8, 2023
@fkanout fkanout mentioned this issue Jun 9, 2023
Merged
13 tasks
fkanout added a commit that referenced this issue Jun 9, 2023
@fkanout
[AO] Create a new rule under Observability plugin based on the metric…
2d4f19e 
…s threshold rule (#158665)

## Summary
### NOTE: This is a draft PR to MVP the new rule combination
(Threshold). More PRs to follow up
It fixes #158260 by providing
the _new_ **Threshold rule**
It fixes #159326

<img width="586" alt="Screenshot 2023-05-30 at 17 55 32"
src="https://github.com/elastic/kibana/assets/6838659/0e485266-d93f-442e-81f4-77aa673ed497">


## ✅ Done 

- [x] Clone the Metric threshold and update the imports 
- [x] The rule is listed in the rule creation flyout with its params and
preview charts
- [x] Working Rule registry
- [x] Working Rule executor 
- [x] Working feature id in the rule registry 
- [x] Working alerts table and alert summary
- [x] Use DataView instead of the Metrics indices under settings
- [x] Update the i18n keys 
- [x] Fix/Update failing checks/tests. Green CI ✅ 
- [x] Hide it behind a feature flag
`xpack.observability.unsafe.thresholdRule.enabled`




## 🏗️ To be done (could be irrelevant, or create a separate issue for
it):
- [ ] <del> Remove the `metrics` word </del>
- [ ] <del> Update file and variable names to match the new rule
context.</del>
- [ ] <del> Rearrange files, constants, and exports </del>

## 🎯 DoD 
Having the rule working like the Metric threshold one and seeing its
related alerts.

---------
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this issue Jun 14, 2023
@fkanout @saarikabhasi
[AO] Create a new rule under Observability plugin based on the metric…
065c765 
…s threshold rule (elastic#158665)

## Summary
### NOTE: This is a draft PR to MVP the new rule combination
(Threshold). More PRs to follow up
It fixes elastic#158260 by providing
the _new_ **Threshold rule**
It fixes elastic#159326

<img width="586" alt="Screenshot 2023-05-30 at 17 55 32"
src="https://github.com/elastic/kibana/assets/6838659/0e485266-d93f-442e-81f4-77aa673ed497">


## ✅ Done 

- [x] Clone the Metric threshold and update the imports 
- [x] The rule is listed in the rule creation flyout with its params and
preview charts
- [x] Working Rule registry
- [x] Working Rule executor 
- [x] Working feature id in the rule registry 
- [x] Working alerts table and alert summary
- [x] Use DataView instead of the Metrics indices under settings
- [x] Update the i18n keys 
- [x] Fix/Update failing checks/tests. Green CI ✅ 
- [x] Hide it behind a feature flag
`xpack.observability.unsafe.thresholdRule.enabled`




## 🏗️ To be done (could be irrelevant, or create a separate issue for
it):
- [ ] <del> Remove the `metrics` word </del>
- [ ] <del> Update file and variable names to match the new rule
context.</del>
- [ ] <del> Rearrange files, constants, and exports </del>

## 🎯 DoD 
Having the rule working like the Metric threshold one and seeing its
related alerts.

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkanout fkanout

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] Create a new rule under Observability plugin based on the metrics threshold rule fkanout/kibana
2 participants
@fkanout @elasticmachine