Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Data Mapper resets after switch to clusters for scaling #158551

Closed
m-adams opened this issue May 26, 2023 · 4 comments · Fixed by #161796
Closed

[Maps] Data Mapper resets after switch to clusters for scaling #158551

m-adams opened this issue May 26, 2023 · 4 comments · Fixed by #161796
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@m-adams
Copy link

m-adams commented May 26, 2023

Kibana version: 8.7.1

Elasticsearch version: 8.7.1

Server OS version: ESS

Browser version: Chrome 113.0.5672.126

Browser OS version: Mac OS 13.4

Original install method (e.g. download page, yum, from source, etc.): ESS

Describe the bug:

In maps, if you use fill by value and data mapper off. If you use clusters for scaling, when you zoom out and it switches from points to clusters the toggle for Data Mapper resets to the default.

Steps to reproduce:

  1. Create a new map with a documents layer
  2. Set scaling to clustering
  3. Set fill by value
  4. Click on Data Mapper and toggle off "Get categories from data set"
  5. Zoom out until the map switches to clusters (or zoom in)
  6. Check the value of "Get categories from data set"

Expected behavior:

The setting should stay at the value selected by the user

Screenshots (if relevant):

Screenshot 2023-05-26 at 11 21 44 Screenshot 2023-05-26 at 11 21 52

Errors in browser console (if relevant): N/A

Provide logs and/or server output (if relevant): N/A

Any additional context:
@m-adams m-adams added bug Fixes for quality problems that affect the customer experience Feature:Maps labels May 26, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 26, 2023
@jsanz jsanz added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label May 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 26, 2023
@jsanz jsanz changed the title Maps. Data Mapper resets after switch to clusters for scaling [Maps] Data Mapper resets after switch to clusters for scaling May 26, 2023
@m-adams
Copy link
Author

m-adams commented May 26, 2023

Here is a recording of the issue
https://github.com/elastic/kibana/assets/7353521/99b66c2a-7074-463f-aef2-6c3db53ea7b7

@m-adams
Copy link
Author

m-adams commented Jul 12, 2023

Hi, is there any update on this issue?

@nreese
Copy link
Contributor

nreese commented Jul 12, 2023 •
edited
Loading

Its a regression introduced by #124289.

DynamicStyleProperty.getFieldMetaOptions is updating readonly state and this is muting redux state outside of dispatch (which is bad).

I can put up a PR to resolve

@nreese nreese self-assigned this Jul 12, 2023
@nreese nreese mentioned this issue Jul 12, 2023
Merged
nreese added a commit that referenced this issue Jul 14, 2023
@nreese @kibanamachine
[maps] fix Data Mapper resets after switch to clusters for scaling (#…
235eac8 
…161796)

Closes #158551

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 14, 2023
@nreese
[maps] fix Data Mapper resets after switch to clusters for scaling (e…
290600a 
…lastic#161796)

Closes elastic#158551

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 235eac8)
kibanamachine referenced this issue Jul 14, 2023
@kibanamachine @nreese
[8.9] [maps] fix Data Mapper resets after switch to clusters for scal…
92ee934 
…ing (#161796) (#161979)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[maps] fix Data Mapper resets after switch to clusters for scaling
(#161796)](#161796)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-07-14T15:11:56Z","message":"[maps]
fix Data Mapper resets after switch to clusters for scaling
(#161796)\n\nCloses
https://github.com/elastic/kibana/issues/158551\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"235eac899b3b64a767c2f900df49be0e7ddeeb5e","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.9.0","v8.10.0"],"number":161796,"url":"https://github.com/elastic/kibana/pull/161796","mergeCommit":{"message":"[maps]
fix Data Mapper resets after switch to clusters for scaling
(#161796)\n\nCloses
https://github.com/elastic/kibana/issues/158551\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"235eac899b3b64a767c2f900df49be0e7ddeeb5e"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161796","number":161796,"mergeCommit":{"message":"[maps]
fix Data Mapper resets after switch to clusters for scaling
(#161796)\n\nCloses
https://github.com/elastic/kibana/issues/158551\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"235eac899b3b64a767c2f900df49be0e7ddeeb5e"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[maps] fix Data Mapper resets after switch to clusters for scaling nreese/kibana
4 participants
@jsanz @nreese @m-adams @elasticmachine