-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log Explorer] Add specialized locators #158382
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
The integration id could be enough @weltenwort? |
An integration could have multiple data streams of type |
When the onboarding succeeds and we have identified that logs are being ingested (issue), there will be a success message in Discover. This seems to need an additional parameter. |
@gbamparop indeed, I was thinking that it could derive the correct message from the origin id that is passed. Does that make sense? |
Is the idea to have a new prop as per below?
There's also the feedback link in Discover. |
If the feedback link would change dynamically based on the specific on-boarding workflow we might need to pass a specific property. But if the feedback link is always the same the log explorer can show it whenever the user comes here with a |
@grabowskit will we have more than one feedback forms? |
@weltenwort As agreed we will keep the implementation of the |
|
📓 Summary
The Discover locators will already include a key to choose the customization profile. In order to support passing data specific to the log explorer profile in a type-safe way, though, we could implement custom locators that wrap the Discover locator.
✔️ Acceptance criteria
savedSearchId
,dataViewId
,indexPatternId
,dataViewSpec
,Profile
are removedid
to describe the workflow and/or step that initiated the navigation. This is the tag of the union.new-integration
without additional properties: for use at the end of the of an on-boarding workflownew-route
with properties for the source integration name and source data stream name: for use at the end of a re-routing workflowExplore Logs
Button at the end of the onboarding flow.💡 Implementation hints
For inspiration/illustration purposes:
The text was updated successfully, but these errors were encountered: