Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Onboarding] Preview imported data and link to logs explorer #154938

Closed
gbamparop opened this issue Apr 13, 2023 · 13 comments
Closed

[Logs Onboarding] Preview imported data and link to logs explorer #154938

gbamparop opened this issue Apr 13, 2023 · 13 comments
Labels
Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@gbamparop
Copy link
Contributor

gbamparop commented Apr 13, 2023

Users will be able to view the most recent incoming log data and navigate to logs explorer.

image

Links

@gbamparop gbamparop added Team:APM All issues that need APM UI Team support apm:logs apm:logs-onboarding and removed apm:logs labels Apr 13, 2023
@gbamparop gbamparop changed the title [APM] Preview imported data and link to logs explorer [Logs Onboarding] Preview imported data and link to logs explorer Apr 17, 2023
@gbamparop
Copy link
Contributor Author

@weltenwort would there be an embeddable available to use in this page?

@weltenwort
Copy link
Member

The log stream embeddable provided by the Logs UI would be available, but it doesn't offer the same usability as the data grid suggested in the mock-up. We hope that we'd be able to offer a similar embeddable based on the Discover-based Log Explorer at some point, but it's not on the near-term roadmap yet.

Can you specify what the requirements for this embeddable would be in terms the visual appearance and data loading behavior?

@gbamparop
Copy link
Contributor Author

Can you specify what the requirements for this embeddable would be in terms the visual appearance and data loading behavior?

I think it's just to see / confirm the new incoming logs during onboarding, before users navigate to the logs page. @isaclfreire might be better to answer this.

@weltenwort
Copy link
Member

weltenwort commented Apr 20, 2023

In yesterday's sync there was a discussion about potentially showing the Log Explorer directly with an option to navigate back instead of embedding something. I've captured the requirement in our project board. Maybe that's a viable alternative?

@isaclfreire
Copy link

Showing the Log Explorer would work for me. I'd just ensure to provide the user a (temporary) success message so to make sure they understood what happened. Here's an example:

Screenshot 2023-04-20 at 12 05 17

@grabowskit
Copy link

Would it be possible to filter on the agent name or id that was just installed? So we can only see the messages in the Logs UI from that agent?

@weltenwort
Copy link
Member

weltenwort commented Apr 26, 2023

@grabowskit yes, that sounds like a good idea

So the set of parameters for that locator would be something like:

  • integration and data stream to select the property entry in the data stream picker
  • agent id to filter the documents by
  • a url or callback that navigates back to previous step of the wizard?

Based on that the Log Explorer would...

  • select the corresponding data stream
  • add a filter for the agent id
  • display a message like the one @isaclfreire with a button that brings the user back to the previous step

Or would the navigation to the previous step make the whole thing too complicated? It's definitely extra effort to re-hydrate the state management of the on-boarding wizard.

@gbamparop
Copy link
Contributor Author

Or would the navigation to the previous step make the whole think too complicated? It's definitely extra effort to re-hydrate the state management of the on-boarding wizard.

IIRC we discussed to not maintain state on the onboarding flow for the MVP but @grabowskit could confirm.

@weltenwort
Copy link
Member

Got it, thanks. If there's no way to return to the wizard, maybe a link back to the "edit" page of the integration would be the next best approach?

@isaclfreire
Copy link

isaclfreire commented Apr 27, 2023 via email

@weltenwort
Copy link
Member

weltenwort commented Apr 27, 2023

Indeed, that could be handled by the same component. 👍 Or a similar component in the same location.

@isaclfreire isaclfreire self-assigned this Apr 27, 2023
@isaclfreire isaclfreire changed the title [Logs Onboarding] Preview imported data and link to logs explorer [Design] Preview imported data and link to logs explorer Apr 27, 2023
@gbamparop gbamparop changed the title [Design] Preview imported data and link to logs explorer [Logs Onboarding] Preview imported data and link to logs explorer May 12, 2023
@gbamparop
Copy link
Contributor Author

Closing this issue as it's no longer relevant. @weltenwort is there an issue we can track for the locator?

@weltenwort
Copy link
Member

@gbamparop yes, I created #158382. Please chime in if you can think of any additional parameters that the on-boarding workflow would like to pass to the log explorer.

@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM All issues that need APM UI Team support apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

No branches or pull requests

4 participants